LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Zhenzhong Duan <zhenzhong.duan@gmail.com>,
	linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com, miguel.ojeda.sandonis@gmail.com,
	willy@haproxy.com, ksenija.stanojevic@gmail.com, arnd@arndb.de,
	mpm@selenic.com, herbert@gondor.apana.org.au,
	jonathan@buzzard.org.uk, benh@kernel.crashing.org,
	davem@davemloft.net, b.zolnierkie@samsung.com, rjw@rjwysocki.net,
	pavel@ucw.cz, len.brown@intel.com,
	William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@reisers.ca>
Subject: Re: [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices
Date: Sat, 14 Mar 2020 23:21:28 +0100	[thread overview]
Message-ID: <20200314222128.mo4q3m72qoy76ayx@function> (raw)
In-Reply-To: <20200309071506.GB4095204@kroah.com>

Hello,

Greg KH, le lun. 09 mars 2020 08:15:06 +0100, a ecrit:
> On Mon, Mar 09, 2020 at 10:17:47AM +0800, Zhenzhong Duan wrote:
> > Arnd notes in the link:
> >    | To clarify: the only numbers that I think should be changed to dynamic
> >    | allocation are for drivers/staging/speakup. While this is a fairly old
> >    | subsystem, I would expect that it being staging means we can be a
> >    | little more progressive with the changes.
> > 
> > This releases misc device minor numbers 25-27 for dynamic usage.
> > 
> > Link: https://lore.kernel.org/lkml/20200120221323.GJ15860@mit.edu/t/
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> > Cc: William Hubbs <w.d.hubbs@gmail.com>
> > Cc: Chris Brannon <chris@the-brannons.com>
> > Cc: Kirk Reiser <kirk@reisers.ca>
> > Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  drivers/staging/speakup/devsynth.c     | 10 +++-------
> >  drivers/staging/speakup/speakup_soft.c | 14 +++++++-------
> >  2 files changed, 10 insertions(+), 14 deletions(-)
> 
> speakup, while being in staging, has been around for a very long time,
> so we might break things if we change their minor numbers.
> 
> I'd need an ACK from the speakup maintainers/developers before I can
> take this as I don't have any way to verify what their systems look
> like.

I believe it will be fine to use dynamic minor numbers, since the /dev
entries are autocreated nowadays, and the espeakup and speechd-up don't
use hardcoded minor values.

Thanks for making sure,
Samuel

  reply	other threads:[~2020-03-15  1:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  2:17 [PATCH RFC 0/3] clean up misc device minor numbers Zhenzhong Duan
2020-03-09  2:17 ` [PATCH RFC 1/3] misc: cleanup minor number definitions in c file into miscdevice.h Zhenzhong Duan
2020-03-09  8:53   ` Herbert Xu
2020-03-11  3:07     ` Zhenzhong Duan
2020-03-09 11:37   ` Miguel Ojeda
2020-03-09 13:08   ` Arnd Bergmann
2020-03-11  2:57     ` Zhenzhong Duan
2020-03-09  2:17 ` [PATCH RFC 2/3] misc: move FLASH_MINOR into miscdevice.h and fix conflicts Zhenzhong Duan
2020-03-09 13:05   ` Arnd Bergmann
2020-03-09  2:17 ` [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices Zhenzhong Duan
2020-03-09  7:15   ` Greg KH
2020-03-14 22:21     ` Samuel Thibault [this message]
2020-03-09  7:13 ` [PATCH RFC 0/3] clean up misc device minor numbers Greg KH
2020-03-09  9:51 ` Willy TARREAU
2020-03-09 11:36   ` Miguel Ojeda
2020-03-11  3:14     ` Zhenzhong Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200314222128.mo4q3m72qoy76ayx@function \
    --to=samuel.thibault@ens-lyon.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=benh@kernel.crashing.org \
    --cc=chris@the-brannons.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jdike@addtoit.com \
    --cc=jonathan@buzzard.org.uk \
    --cc=kirk@reisers.ca \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mpm@selenic.com \
    --cc=pavel@ucw.cz \
    --cc=richard@nod.at \
    --cc=rjw@rjwysocki.net \
    --cc=w.d.hubbs@gmail.com \
    --cc=willy@haproxy.com \
    --cc=zhenzhong.duan@gmail.com \
    --subject='Re: [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).