LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"josua@solid-run.com" <josua@solid-run.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: mvmdio: avoid error message for optional IRQ
Date: Mon, 16 Mar 2020 09:38:00 +0100	[thread overview]
Message-ID: <20200316083800.GB8524@lunn.ch> (raw)
In-Reply-To: <63905ad2134b4d19cb274c9e082a9326a07991ac.camel@alliedtelesis.co.nz>

> Actually on closer inspection I think this is wrong.
> platform_get_irq_optional() will return -ENXIO if the irq is not
> specified.

The _optional is then pointless. And different to all the other
_optional functions which don't return an error if the property is not
defined.

Are you really sure about this? I don't have the time right now to
check.

	Andrew

  reply	other threads:[~2020-03-16  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 20:05 Chris Packham
2020-03-12  7:03 ` David Miller
2020-03-16  7:29 ` Chris Packham
2020-03-16  8:38   ` Andrew Lunn [this message]
2020-03-16  9:32     ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316083800.GB8524@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=davem@davemloft.net \
    --cc=josua@solid-run.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v2] net: mvmdio: avoid error message for optional IRQ' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).