LKML Archive on
help / color / mirror / Atom feed
From: Miroslav Benes <>
	Miroslav Benes <>
Subject: [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable
Date: Thu, 19 Mar 2020 10:56:05 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The unwinder reports the boot CPU idle task's stack on XEN PV as
unreliable, which affects at least live patching. There are two reasons
for this. First, the task does not follow the x86 convention that its
stack starts at the offset right below saved pt_regs. It allows the
unwinder to easily detect the end of the stack and verify it. Second,
startup_xen() function does not store the return address before jumping
to xen_start_kernel() which confuses the unwinder.

Amend both issues by moving the starting point of initial stack in
startup_xen() and storing the return address before the jump, which is
exactly what call instruction does.

Signed-off-by: Miroslav Benes <>
 arch/x86/xen/xen-head.S | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index 1d0cee3163e4..edc776af0e0a 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -35,7 +35,11 @@ SYM_CODE_START(startup_xen)
 	rep __ASM_SIZE(stos)
 	mov %_ASM_SI, xen_start_info
-	mov $init_thread_union+THREAD_SIZE, %_ASM_SP
+#ifdef CONFIG_X86_64
+	mov initial_stack(%rip), %_ASM_SP
+	mov pa(initial_stack), %_ASM_SP
 #ifdef CONFIG_X86_64
 	/* Set up %gs.
@@ -51,7 +55,7 @@ SYM_CODE_START(startup_xen)
-	jmp xen_start_kernel
+	call xen_start_kernel

  reply	other threads:[~2020-03-19  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  9:56 [PATCH v2 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
2020-03-19  9:56 ` Miroslav Benes [this message]
2020-03-19 10:01   ` [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable Jan Beulich
2020-03-19 10:31     ` Miroslav Benes
2020-03-19  9:56 ` [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
2020-03-19 10:03   ` Jan Beulich
2020-03-19 10:38     ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).