From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52880C4332D for ; Thu, 19 Mar 2020 18:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B6E52070A for ; Thu, 19 Mar 2020 18:01:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l0WeQLfY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727269AbgCSSBe (ORCPT ); Thu, 19 Mar 2020 14:01:34 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:50338 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbgCSSBd (ORCPT ); Thu, 19 Mar 2020 14:01:33 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C8FDFA53; Thu, 19 Mar 2020 19:01:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584640891; bh=J0G9o/JIk2L9YAMrgEYnSflrJ+3mDjoCeRH1I4lPqik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l0WeQLfY4oPvGyf+T8Bwr1JXg9rF3wSCsAL/YwHYR/F4V+bPvcMIBVex2/JmFRkPq wH0uwGnyJ0/qvbpO0VFVj+sYnrBU90JDCIx7sBKD7tzafPZrokKyt3pDfmx4om2Nkv yNo/D2bEwfHVQcIjR59Xc9qhUHFpFJvvzC1CHe/o= Date: Thu, 19 Mar 2020 20:01:25 +0200 From: Laurent Pinchart To: Alex Riesen Cc: Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Message-ID: <20200319180125.GJ14585@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, Thank you for the patch. On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote: > As the driver has some support for the audio interface of the device, > the bindings file should mention it. While at it, how about converting the bindings to YAML ? :-) It can of course be done on top. > Reviewed-by: Rob Herring > Signed-off-by: Alexander Riesen > --- > .../devicetree/bindings/media/i2c/adv748x.txt | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > index 4f91686e54a6..7d6db052c294 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -2,7 +2,9 @@ > > The ADV7481 and ADV7482 are multi format video decoders with an integrated > HDMI receiver. They can output CSI-2 on two independent outputs TXA and TXB > -from three input sources HDMI, analog and TTL. > +from three input sources HDMI, analog and TTL. There is also support for an > +I2S compatible interface connected to the audio processor of the HDMI decoder. s/I2S compatible/I2S-compatible/ ? > +The interface has TDM capability (8 slots, 32 bits, left or right justified). > > Required Properties: > > @@ -16,6 +18,8 @@ Required Properties: > slave device on the I2C bus. The main address is mandatory, others are > optional and remain at default values if not specified. > > + - #clock-cells: must be <0> if the I2S port is used Wouldn't it be simpler to set it to 0 unconditionally ? Reviewed-by: Laurent Pinchart > + > Optional Properties: > > - interrupt-names: Should specify the interrupts as "intrq1", "intrq2" and/or > @@ -47,6 +51,7 @@ are numbered as follows. > TTL sink 9 > TXA source 10 > TXB source 11 > + I2S source 12 > > The digital output port nodes, when present, shall contain at least one > endpoint. Each of those endpoints shall contain the data-lanes property as > @@ -72,6 +77,7 @@ Example: > > #address-cells = <1>; > #size-cells = <0>; > + #clock-cells = <0>; > > interrupt-parent = <&gpio6>; > interrupt-names = "intrq1", "intrq2"; > @@ -113,4 +119,12 @@ Example: > remote-endpoint = <&csi20_in>; > }; > }; > + > + port@c { > + reg = <12>; > + > + adv7482_i2s: endpoint { > + remote-endpoint = <&i2s_in>; > + }; > + }; > }; -- Regards, Laurent Pinchart