LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Alex Riesen <alexander.riesen@cetitec.com>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements
Date: Thu, 19 Mar 2020 20:03:31 +0200 [thread overview]
Message-ID: <20200319180331.GK14585@pendragon.ideasonboard.com> (raw)
In-Reply-To: <5272d873b4daf8b0bdb8aff81b08ab3508da9567.1584639664.git.alexander.riesen@cetitec.com>
Hi Alex,
Thank you for the patch.
On Thu, Mar 19, 2020 at 06:41:43PM +0100, Alex Riesen wrote:
> Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 24 ++++++++++++------------
> drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 23e02ff27b17..c3fb113cef62 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -623,11 +623,11 @@ static int adv748x_parse_dt(struct adv748x_state *state)
>
> for_each_endpoint_of_node(state->dev->of_node, ep_np) {
> of_graph_parse_endpoint(ep_np, &ep);
> - adv_info(state, "Endpoint %pOF on port %d", ep.local_node,
> + adv_info(state, "Endpoint %pOF on port %d\n", ep.local_node,
> ep.port);
>
> if (ep.port >= ADV748X_PORT_MAX) {
> - adv_err(state, "Invalid endpoint %pOF on port %d",
> + adv_err(state, "Invalid endpoint %pOF on port %d\n",
> ep.local_node, ep.port);
>
> continue;
> @@ -635,7 +635,7 @@ static int adv748x_parse_dt(struct adv748x_state *state)
>
> if (state->endpoints[ep.port]) {
> adv_err(state,
> - "Multiple port endpoints are not supported");
> + "Multiple port endpoints are not supported\n");
> continue;
> }
>
> @@ -702,62 +702,62 @@ static int adv748x_probe(struct i2c_client *client)
> /* Discover and process ports declared by the Device tree endpoints */
> ret = adv748x_parse_dt(state);
> if (ret) {
> - adv_err(state, "Failed to parse device tree");
> + adv_err(state, "Failed to parse device tree\n");
> goto err_free_mutex;
> }
>
> /* Configure IO Regmap region */
> ret = adv748x_configure_regmap(state, ADV748X_PAGE_IO);
> if (ret) {
> - adv_err(state, "Error configuring IO regmap region");
> + adv_err(state, "Error configuring IO regmap region\n");
> goto err_cleanup_dt;
> }
>
> ret = adv748x_identify_chip(state);
> if (ret) {
> - adv_err(state, "Failed to identify chip");
> + adv_err(state, "Failed to identify chip\n");
> goto err_cleanup_dt;
> }
>
> /* Configure remaining pages as I2C clients with regmap access */
> ret = adv748x_initialise_clients(state);
> if (ret) {
> - adv_err(state, "Failed to setup client regmap pages");
> + adv_err(state, "Failed to setup client regmap pages\n");
> goto err_cleanup_clients;
> }
>
> /* SW reset ADV748X to its default values */
> ret = adv748x_reset(state);
> if (ret) {
> - adv_err(state, "Failed to reset hardware");
> + adv_err(state, "Failed to reset hardware\n");
> goto err_cleanup_clients;
> }
>
> /* Initialise HDMI */
> ret = adv748x_hdmi_init(&state->hdmi);
> if (ret) {
> - adv_err(state, "Failed to probe HDMI");
> + adv_err(state, "Failed to probe HDMI\n");
> goto err_cleanup_clients;
> }
>
> /* Initialise AFE */
> ret = adv748x_afe_init(&state->afe);
> if (ret) {
> - adv_err(state, "Failed to probe AFE");
> + adv_err(state, "Failed to probe AFE\n");
> goto err_cleanup_hdmi;
> }
>
> /* Initialise TXA */
> ret = adv748x_csi2_init(state, &state->txa);
> if (ret) {
> - adv_err(state, "Failed to probe TXA");
> + adv_err(state, "Failed to probe TXA\n");
> goto err_cleanup_afe;
> }
>
> /* Initialise TXB */
> ret = adv748x_csi2_init(state, &state->txb);
> if (ret) {
> - adv_err(state, "Failed to probe TXB");
> + adv_err(state, "Failed to probe TXB\n");
> goto err_cleanup_txa;
> }
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c
> index 2091cda50935..c43ce5d78723 100644
> --- a/drivers/media/i2c/adv748x/adv748x-csi2.c
> +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c
> @@ -72,7 +72,7 @@ static int adv748x_csi2_registered(struct v4l2_subdev *sd)
> struct adv748x_state *state = tx->state;
> int ret;
>
> - adv_dbg(state, "Registered %s (%s)", is_txa(tx) ? "TXA":"TXB",
> + adv_dbg(state, "Registered %s (%s)\n", is_txa(tx) ? "TXA":"TXB",
> sd->name);
>
> /*
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-19 18:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 17:41 [PATCH v2 00/10] media: adv748x: add support for HDMI audio Alex Riesen
2020-03-19 17:41 ` [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen
2020-03-19 18:03 ` Laurent Pinchart [this message]
2020-03-19 17:41 ` [PATCH v2 02/10] media: adv748x: include everything adv748x.h needs into the file Alex Riesen
2020-03-19 17:48 ` Laurent Pinchart
2020-03-20 8:23 ` Alex Riesen
2020-03-19 17:41 ` [PATCH v2 03/10] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen
2020-03-19 18:06 ` Laurent Pinchart
2020-03-20 9:08 ` Alex Riesen
2020-03-19 17:41 ` [PATCH v2 04/10] media: adv748x: add definitions for audio output related registers Alex Riesen
2020-03-19 17:42 ` [PATCH v2 05/10] media: adv748x: add support for HDMI audio Alex Riesen
2020-03-20 8:43 ` Geert Uytterhoeven
2020-03-20 8:57 ` Alex Riesen
2020-03-20 9:10 ` Geert Uytterhoeven
2020-03-20 10:58 ` Alex Riesen
2020-03-20 11:05 ` Geert Uytterhoeven
2020-03-20 11:11 ` Alex Riesen
2020-03-19 17:42 ` [PATCH v2 06/10] media: adv748x: only activate DAI if it is described in device tree Alex Riesen
2020-03-19 17:42 ` [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen
2020-03-19 18:01 ` Laurent Pinchart
2020-03-20 8:44 ` Alex Riesen
2020-03-20 8:48 ` Geert Uytterhoeven
2020-03-20 9:03 ` Alex Riesen
2020-03-20 9:15 ` Geert Uytterhoeven
2020-03-20 9:18 ` Alex Riesen
2020-03-20 9:59 ` Laurent Pinchart
2020-03-20 16:15 ` Alex Riesen
2020-03-19 17:42 ` [PATCH v2 08/10] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen
2020-03-23 0:12 ` Kuninori Morimoto
2020-03-23 7:35 ` Alex Riesen
2020-03-19 17:42 ` [PATCH v2 09/10] media: adv748x: add support for log_status ioctl Alex Riesen
2020-03-19 17:43 ` [PATCH v2 10/10] media: adv748x: allow the HDMI sub-device to accept EDID Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319180331.GK14585@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alexander.riesen@cetitec.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH v2 01/10] media: adv748x: fix end-of-line terminators in diagnostic statements' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).