From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C21C4332D for ; Fri, 20 Mar 2020 08:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 476D620752 for ; Fri, 20 Mar 2020 08:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726986AbgCTI6J (ORCPT ); Fri, 20 Mar 2020 04:58:09 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60111 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgCTI6I (ORCPT ); Fri, 20 Mar 2020 04:58:08 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mo7if-1jeAAm1Fxz-00pewW; Fri, 20 Mar 2020 09:57:51 +0100 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id D01EF64E13A; Fri, 20 Mar 2020 08:57:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8WVdriKV_24H; Fri, 20 Mar 2020 09:57:49 +0100 (CET) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 88A6664E076; Fri, 20 Mar 2020 09:57:49 +0100 (CET) Received: from pflmari.corp.cetitec.com (10.8.5.41) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 20 Mar 2020 09:57:49 +0100 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 03CEB80524; Fri, 20 Mar 2020 09:57:49 +0100 (CET) Date: Fri, 20 Mar 2020 09:57:48 +0100 From: Alex Riesen To: Geert Uytterhoeven CC: Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , "Laurent Pinchart" , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , "Linux Kernel Mailing List" , Device Tree Mailing List , Linux-Renesas , linux-clk Subject: Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio Message-ID: <20200320085748.GC4344@pflmari> Mail-Followup-To: Alex Riesen , Geert Uytterhoeven , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , Device Tree Mailing List , Linux-Renesas , linux-clk References: <252bb433f47b0ccb61bb077abdbd892091abc550.1584639664.git.alexander.riesen@cetitec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.41] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6D7764 X-Provags-ID: V03:K1:wVJ3OvhV0Lvry0hgcgROi8Lpbax9cgifbiymKG7FRbbbjAK1rX0 Is0O+5SFuT17dvunKoqEGCwkjWmyvRAwfuARYtS+7Hfh785pgLXdL6dcbIOi6sp+zn7cFrT lwdJU/vpOTIFoz3tYZKAhrUG8jPAGIhmJumC2obezAomNKeWhJ91+U2KXS752GQWo3q5RJU RLerO04OwjnEpPnGC9Vzg== X-UI-Out-Filterresults: notjunk:1;V03:K0:uNMETWAQjQg=:vLEFwoWAelStQ0k7nCUVNT aCVw9ozlhp45UIJqEh/USKF9RgevErT2upztWoeYjACvqVIBIEEogFQakTQsiipMm1CDW6MoB XnAqzycEx64LZ7rmN470XIj0avElWBShMm+zyN0K2t+JFt5vKLHhwY7YGPIMVwy+yTdTjg/rP 99SU4WMGxUt8ulLUdPsgVEGgnLsdBnoVsblpGsM+gwxjCXNLDMNREKAGv8ixgE+UJZtJIfRp+ FpZKH0yADUGcZxKDOKzCCeNPxN0YgxIrGG5Jpz3pek3PLzaZW/GCxen9LZuQhsV4LyeuXWL5C F576r7CXv9zaxd9eScgDaeta68I2xklolW2cfo0R4Ks2azs4lyo2BAkuJb5xRbKL7j2RSYcKS plEGX4KSs1je913qrf44VhgZKzN8GmeC8GlJTcn+Xt24pyfb922HVEBfsMSm/caWpBiXsino+ yJhgeuycnrseXlpENT78oBd+OW6/ocUNj/XmiQXkJfISAfriZTRLYjdCQsNoaZsq0MtbRwPxN qesn7vFjAbM9aEbZsHF2ePInrD4g1ESAVo4Re5KPNpOHY60kZ/RJx2mh+tCTTWkjPnT3BVTk/ A9y363R6OQ707Kn37QjqY+ed8vOBKtMCvnzGzwAoI9rA5iggSnPcK3MPYm+764GfEistE89xM 6+jnmggijWTyUVottTgIJw4aW3JloGlsTJTHmzylgjb350BLxlpBR3rljcJsUiah7j4LfJuOG ey9WEan1X3myyUZLH9tZ0LbI5sPAoaMMPYSvSkuAXMxp/UqhPsJecI5Q4wLpY2OLfUdQWZDui u+GNLb6zZ5GFBuSzElEldypinSlBLkPjv80wi8buFIT3E1KE8Qi5vo6jIGuBv9llBUigJ87 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > CC linux-clk for the clock provider. Thanks! > > +int adv748x_dai_init(struct adv748x_dai *dai) > > +{ > > + int ret; > > + struct adv748x_state *state = adv748x_dai_to_state(dai); > > + > > + dai->mclk = clk_register_fixed_rate(state->dev, > > + "adv748x-hdmi-i2s-mclk", > > I assume there can be multiple adv748x instances in the system? > Hence the clock name should be unique for each instance. I think that can happen. Is it alright to derive the clock name from the device name? E.g.: adv748x.4-0070-mclk? Where "adv748x.4-0070" is a struct device->name. Regards, Alex