From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA593C4332D for ; Fri, 20 Mar 2020 09:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C77A820752 for ; Fri, 20 Mar 2020 09:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbgCTJD6 (ORCPT ); Fri, 20 Mar 2020 05:03:58 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:34269 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbgCTJD6 (ORCPT ); Fri, 20 Mar 2020 05:03:58 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M7ehh-1jCDQW3SRx-007yVL; Fri, 20 Mar 2020 10:03:41 +0100 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id A47C164FAB0; Fri, 20 Mar 2020 09:03:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x-5ITaYeBHjU; Fri, 20 Mar 2020 10:03:40 +0100 (CET) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 36B6864F411; Fri, 20 Mar 2020 10:03:40 +0100 (CET) Received: from pflmari.corp.cetitec.com (10.8.5.41) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 20 Mar 2020 10:03:40 +0100 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 816CF8051E; Fri, 20 Mar 2020 10:03:39 +0100 (CET) Date: Fri, 20 Mar 2020 10:03:39 +0100 From: Alex Riesen To: Geert Uytterhoeven CC: Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , "Linux Kernel Mailing List" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Subject: Re: [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Message-ID: <20200320090339.GD4344@pflmari> Mail-Followup-To: Alex Riesen , Geert Uytterhoeven , Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas References: <20200319180125.GJ14585@pendragon.ideasonboard.com> <20200320084406.GB4344@pflmari> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.41] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6D7764 X-Provags-ID: V03:K1:+c5uHQqjAAPvLBL8uGlPO7w2cxG5XARvcAeG5tV+1WSuK/v3k1v TKcEGeFtoTMqbgnfWh8ohKC3B3Vl7Rtc+nz0Sy8Qv0Iqt+OSofmWR/TJ5dObvjA+pOI7Vu9 j0YkguCfdlieSLV7baZP3wPPS3azYeAjsimaO6cZ5r7D+bGA/YOZvJzxc3G37tZc3QIRJ9z CdpAwqkbKaO7YGZbPyMbg== X-UI-Out-Filterresults: notjunk:1;V03:K0:p099hMf9aNY=:qUne0yZBhfBH7BpGl+6Htu /DTcV1Sp181HSqNXmYOut6n/rBklQ/5Twxge1A7pEGPpUffwXFMLYwyqUez7Ktzmx8e5hfVSC 7dUnWCZINCSX7C6TGsQhjn7LIrVpAynvHiNd85GL1LBJTzp4KbxBAC1DtLYAq2M7UyAHL+bUR q9x5aLE/E4fDztBUAu0oo4RMvwpK+LEsm1VLwBbeqH2i6qVXtJA2VAGLDWCvOE2eVEmwJM6EZ oZ+D80fm73H+/xu/c3Y+qBNL6Nt4nYRs6gqilgFZd+8oltfcPAM4ba8LWt8aB5WrWvOLWtUp9 m7eVL4wcluZnCqAxWsIiYlXF2swF+idIIx8xqWprcViKowLBq/HWLX6EqZSzr+uEak60YtTUO AQ7Ed/qwM11KCrYxoeOiJdp+rOG3jVe0c1OI2LsUI4EkhbEGt/PyxDHkJLnR/t6At2bWdlpfI LqtyTVal2LIYnDFfd51cp/Q/gfSRjNnkPhw8z56/8P/nrczRVWifRrgVq6G+CvQ048Alv9ZJm 7t31Hi8B+mOxsDD7tXG8DuuK4PDK9VRjxCadlg99fI5JKXBhgzhcYe2gm35Uy2vaqUpTUWMz7 XdYVqUlQFVWYiebV6iXfXuaIuEckRrs4/o2KBH2lsOMZB0wxAppEsn1ktXsHyyNAOxw9tgrCl XOoOy9nCnJy4KXghc6eQI1WZfmnyGrL4iQE1E46AzPP9NSihLGAPAPuhCtL9jqCwjnX3Ij4yw l4HxfBXuxw9yOCoV7tk+i0RFRgY7QC00WpzfLqPNtf03GUFMjVdg9CORefpGDTqsyx+8Rn+O8 z9aw57YjV7YaT+ef6FxSThoUQwJw1w32NGt9gb32RFvEzral7BtKhwPy1jDtK7El669kqEG Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100: > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen wrote: > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100: > > > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote: > > > > As the driver has some support for the audio interface of the device, > > > > the bindings file should mention it. > > > > > @@ -16,6 +18,8 @@ Required Properties: > > > > slave device on the I2C bus. The main address is mandatory, others are > > > > optional and remain at default values if not specified. > > > > > > > > + - #clock-cells: must be <0> if the I2S port is used > > > > > > Wouldn't it be simpler to set it to 0 unconditionally ? > > > > Would it? If the port itself is optional, shouldn't the clock be an option > > too? > > You'd be surprised how many board designers would consider this a cheap > 12.288 MHz clock source, without using the I2S port ;-) Well, I am :-) Especially considering that the driver will not switch the MCLK pin aktive (all I2S-related pins are tristate by default). And how do I require it to be set unconditionally? By just removing the "if ..." part of the statement? Regards, Alex