LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sandeep Patil <sspatil@android.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@android.com
Subject: Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header
Date: Tue, 31 Mar 2020 17:22:51 -0700	[thread overview]
Message-ID: <20200401002251.GA177505@google.com> (raw)
In-Reply-To: <6b947adc-a176-5fa0-1382-8b08ec3f8b09@ti.com>

On Tue, Mar 10, 2020 at 03:09:37PM -0500, Dan Murphy wrote:
> Hello
> 
> On 3/6/20 5:55 PM, Sandeep Patil wrote:
> > Hi Sebastian,
> > 
> > On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote:
> > > > Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> > > > 
> > > > Signed-off-by: Dan Murphy <dmurphy@ti.com>
> > > > ---
> > > Looks good. But I will not merge it without a user and have comments
> > > for the driver.
> > Android has been looking for these properties for a while now [1].
> > It was added[2] when we saw that the manufacturers were implementing these
> > properties in the driver. I didn't know the properties were absent upstream
> > until yesterday. Somebody pointed out in our ongoing effort to make sure
> > all core kernel changes that android depends on are present upstream.
> > 
> > I think those values are also propagated in application facing APIs in
> > Android (but I am not sure yet, let me know if that's something you want
> > to find out).
> > 
> > I wanted to chime in and present you a 'user' for this if that helps.
> 
> We have re-submitted the BQ25150/155 driver that would be the user and we
> have 2 more for review that will use the new definitions

Dan / Sebastian, I wasn't able to find the subsequent patches
that add the 3 health properties, so I'm assuming this patch is still
"out-of-tree".

I was hoping against that so we (Android) aren't unnecessarily diverging
from upstream. However, I have now just cherry-picked this patch[1] for the
next Android release.

Sebastian, since these appear in JEITA spec, will the same patch with
additions to the commit message saying so be enough?

Thanks,
- ssp

1. https://android-review.googlesource.com/c/kernel/common/+/1275596

> 
> Dan
> 

  reply	other threads:[~2020-04-01  0:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 17:50 [PATCH v4 0/4] BQ25150/155 Driver introduction Dan Murphy
2020-01-16 17:50 ` [PATCH v4 1/4] power: supply: core: Update sysfs-class-power ABI document Dan Murphy
2020-01-17  1:05   ` Sebastian Reichel
2020-01-16 17:50 ` [PATCH v4 2/4] power_supply: Add additional health properties to the header Dan Murphy
2020-01-17  1:06   ` Sebastian Reichel
2020-03-06 23:55     ` Sandeep Patil
2020-03-10 20:09       ` Dan Murphy
2020-04-01  0:22         ` Sandeep Patil [this message]
2020-03-10 21:30       ` Sebastian Reichel
2020-03-11 11:29         ` Dan Murphy
2020-03-11 16:43           ` [EXTERNAL] " Ricardo Rivera-Matos
2020-03-14  4:12             ` Sandeep Patil
2020-03-03 20:33   ` Guru Das Srinagesh
2020-01-16 17:50 ` [PATCH v4 3/4] dt-bindings: power: Add the bq2515x family dt bindings Dan Murphy
2020-01-17  1:05   ` Sebastian Reichel
2020-01-16 17:50 ` [PATCH v4 4/4] power: supply: bq2515x: Introduce the bq2515x family Dan Murphy
2020-01-17  1:01   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401002251.GA177505@google.com \
    --to=sspatil@android.com \
    --cc=dmurphy@ti.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --subject='Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).