LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux@rasmusvillemoes.dk, dan.j.williams@intel.com,
	peterz@infradead.org
Subject: Re: [PATCH v6 2/2] lib: make a test module with set/clear bit
Date: Wed, 15 Apr 2020 17:46:23 +0300	[thread overview]
Message-ID: <20200415144623.GJ185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200310221747.2848474-2-jesse.brandeburg@intel.com>

On Tue, Mar 10, 2020 at 03:17:47PM -0700, Jesse Brandeburg wrote:
> Test some bit clears/sets to make sure assembly doesn't change, and
> that the set_bit and clear_bit functions work and don't cause sparse
> warnings.
> 
> Instruct Kbuild to build this file with extra warning level -Wextra,
> to catch new issues, and also doesn't hurt to build with C=1.
> 
> This was used to test changes to arch/x86/include/asm/bitops.h.
> 
> In particular, sparse (C=1) was very concerned when the last bit
> before a natural boundary, like 7, or 31, was being tested, as this
> causes sign extension (0xffffff7f) for instance when clearing bit 7.
> 
> Recommended usage:
> make defconfig
> scripts/config -m CONFIG_TEST_BITOPS
> make modules_prepare
> make C=1 W=1 lib/test_bitops.ko
> objdump -S -d lib/test_bitops.ko
> insmod lib/test_bitops.ko
> rmmod lib/test_bitops.ko
> <check dmesg>, there should be no compiler/sparse warnings and no
> error messages in log.

Seems this didn't make the kernel. Perhaps you need to send it to Andrew Morton.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-15 14:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 22:17 [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast Jesse Brandeburg
2020-03-10 22:17 ` [PATCH v6 2/2] lib: make a test module with set/clear bit Jesse Brandeburg
2020-04-15 14:46   ` Andy Shevchenko [this message]
2020-03-11  4:37 ` [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast Luc Van Oostenryck
2020-03-17 19:25 ` Peter Zijlstra
2020-03-18 21:59 ` [tip: x86/asm] x86: Fix " tip-bot2 for Jesse Brandeburg
2020-05-04 19:37 ` [PATCH v6 1/2] x86: fix " Nick Desaulniers
2020-05-05  1:14   ` Jesse Brandeburg
2020-05-05 15:14     ` Andy Shevchenko
2020-05-05 17:29       ` Nick Desaulniers
2020-05-05 17:47         ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415144623.GJ185537@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v6 2/2] lib: make a test module with set/clear bit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).