From: Leo Yan <leo.yan@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ahmed S. Darwish" <a.darwish@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
John Ogness <jogness@linutronix.de>,
"Sebastian A. Siewior" <bigeasy@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] time/sched_clock: Use raw_read_seqcount_latch()
Date: Thu, 16 Jul 2020 13:22:59 +0800
Message-ID: <20200716052259.GA4660@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20200715155850.GL10769@hirez.programming.kicks-ass.net>
Hi Peter, Ahemd,
On Wed, Jul 15, 2020 at 05:58:50PM +0200, Peter Zijlstra wrote:
[...]
> > > diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c
> > > index fa3f800d7d76..ea007928d681 100644
> > > --- a/kernel/time/sched_clock.c
> > > +++ b/kernel/time/sched_clock.c
> > > @@ -100,7 +100,7 @@ unsigned long long notrace sched_clock(void)
> > > struct clock_read_data *rd;
> > >
> > > do {
> > > - seq = raw_read_seqcount(&cd.seq);
> > > + seq = raw_read_seqcount_latch(&cd.seq);
> >
> > Understand this is doing the same thing with __ktime_get_fast_ns() and
> > I saw Peter acked to make change for this.
> >
> > Just want to confirm, since this patch introduces conflict with the
> > patch set "arm64: perf: Proper cap_user_time* support" [1], I should
> > rebase the patch set on top of this patch, right?
>
> Or rebase this patch on top of yours and include it, either way.
Have rebased this patch and included it in the patch set v3 for
"arm64: perf: Proper cap_user_time* support" [1].
Thanks!
Leo
[1] https://lore.kernel.org/linux-arm-kernel/20200716051130.4359-3-leo.yan@linaro.org/T/#u
next prev parent reply index
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 2:05 [PATCH v2 0/6] arm64: perf: Proper cap_user_time* support Leo Yan
2020-07-15 2:05 ` [PATCH v2 1/6] sched_clock: Expose struct clock_read_data Leo Yan
2020-07-15 5:56 ` Ahmed S. Darwish
2020-07-15 6:54 ` Leo Yan
2020-07-15 7:21 ` Ahmed S. Darwish
2020-07-15 8:12 ` Peter Zijlstra
2020-07-15 8:14 ` peterz
2020-07-15 9:23 ` Ahmed S. Darwish
2020-07-15 9:52 ` Peter Zijlstra
2020-07-15 11:59 ` [PATCH] time/sched_clock: Use raw_read_seqcount_latch() Ahmed S. Darwish
2020-07-15 15:29 ` Leo Yan
2020-07-15 15:58 ` Peter Zijlstra
2020-07-16 5:22 ` Leo Yan [this message]
2020-09-10 15:08 ` [tip: locking/core] time/sched_clock: Use raw_read_seqcount_latch() during suspend tip-bot2 for Ahmed S. Darwish
2020-07-15 2:05 ` [PATCH v2 2/6] arm64: perf: Implement correct cap_user_time Leo Yan
2020-07-15 8:38 ` Peter Zijlstra
2020-07-15 15:39 ` Leo Yan
2020-07-15 2:05 ` [PATCH v2 3/6] arm64: perf: Only advertise cap_user_time for arch_timer Leo Yan
2020-07-15 2:05 ` [PATCH v2 4/6] perf: Add perf_event_mmap_page::cap_user_time_short ABI Leo Yan
2020-07-15 2:05 ` [PATCH v2 5/6] arm64: perf: Add cap_user_time_short Leo Yan
2020-07-15 2:05 ` [PATCH v2 6/6] tools headers UAPI: Update tools's copy of linux/perf_event.h Leo Yan
2020-07-15 5:17 ` [PATCH v2 0/6] arm64: perf: Proper cap_user_time* support Ahmed S. Darwish
2020-07-15 6:29 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716052259.GA4660@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=a.darwish@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=jogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git
git clone --mirror https://lkml.kernel.org/lkml/10 lkml/git/10.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git