From: "Ahmed S. Darwish" <a.darwish@linutronix.de> To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me> Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: v5.9-rc1 commit reliably breaks pci nvme detection Date: Mon, 17 Aug 2020 15:50:11 +0200 Message-ID: <20200817135011.GA2072@lx-t490> (raw) Hello, Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 laptop. PCI nvme detection fails, and the kernel becomes not able anymore to find the rootfs / parse "root=". Bisecting v5.8=>v5.9-rc1 blames that commit. Reverting it *reliably* fixes the problem and makes me able to boot v5.9-rc1. Please advise. commit 61f3b89630973037f67d8e25e5d26e80a51a7b37 Author: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Date: Wed Jun 17 10:05:13 2020 +0200 nvme-pci: use unsigned for io queue depth The NVMe PCIe declares module parameter io_queue_depth as int. Change this to u16 as queue depth can never be negative. Now to reflect this update module parameter getter function from param_get_int() -> param_get_uint() and respective setter function with type of n changed from int to u16 with param_set_int() to param_set_ushort(). Finally update struct nvme_dev q_depth member to u16 and use u16 in min_t() when calculating dev->q_depth in the nvme_pci_enable() (since q_depth is now u16) and use unsigned int instead of int when calculating dev->tagset.queue_depth as target variable tagset->queue_depth is of type unsigned int in nvme_dev_add(). Thanks, -- Ahmed S. Darwish Linutronix GmbH
next reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 13:50 Ahmed S. Darwish [this message] 2020-08-17 15:56 ` Keith Busch 2020-08-17 15:58 ` Jens Axboe 2020-08-20 15:35 ` Jens Axboe 2020-08-20 17:07 ` Ahmed S. Darwish 2020-08-20 17:10 ` Jens Axboe 2020-08-20 17:12 ` Christoph Hellwig 2020-08-20 17:14 ` Jens Axboe 2020-08-21 7:28 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817135011.GA2072@lx-t490 \ --to=a.darwish@linutronix.de \ --cc=axboe@fb.com \ --cc=chaitanya.kulkarni@wdc.com \ --cc=kbusch@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git