LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock
@ 2020-09-18 11:47 Yannick Fertre
2020-09-24 19:52 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Yannick Fertre @ 2020-09-18 11:47 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Antonio Borneo, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
From: Antonio Borneo <antonio.borneo@st.com>
The panel is able to work when dsi clock is non-continuous, thus
the system power consumption can be reduced using such feature.
Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags.
Signed-off-by: Antonio Borneo <antonio.borneo@st.com>
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
index b6e377aa1131..6ac1accade80 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
@@ -452,7 +452,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
dsi->lanes = 2;
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
- MIPI_DSI_MODE_LPM;
+ MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
drm_panel_init(&ctx->panel, dev, &otm8009a_drm_funcs,
DRM_MODE_CONNECTOR_DSI);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock
2020-09-18 11:47 [PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock Yannick Fertre
@ 2020-09-24 19:52 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-09-24 19:52 UTC (permalink / raw)
To: Yannick Fertre
Cc: Philippe Cornu, Antonio Borneo, Thierry Reding, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
On Fri, Sep 18, 2020 at 01:47:26PM +0200, Yannick Fertre wrote:
> From: Antonio Borneo <antonio.borneo@st.com>
>
> The panel is able to work when dsi clock is non-continuous, thus
> the system power consumption can be reduced using such feature.
>
> Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags.
>
> Signed-off-by: Antonio Borneo <antonio.borneo@st.com>
Patch looks good - but I have no clue if the panel supports it or not.
Anyway:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index b6e377aa1131..6ac1accade80 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -452,7 +452,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> dsi->lanes = 2;
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> - MIPI_DSI_MODE_LPM;
> + MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
>
> drm_panel_init(&ctx->panel, dev, &otm8009a_drm_funcs,
> DRM_MODE_CONNECTOR_DSI);
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-24 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 11:47 [PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock Yannick Fertre
2020-09-24 19:52 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).