LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Prasad Sodagudi <psodagud@codeaurora.org>
Cc: rostedt@goodmis.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, tkjos@google.com
Subject: Re: [PATCH 1/2] genirq/cpuhotplug: Reduce logging level for couple of prints
Date: Thu, 24 Sep 2020 08:31:52 +0200 [thread overview]
Message-ID: <20200924063152.GA592892@kroah.com> (raw)
In-Reply-To: <1600906112-126722-1-git-send-email-psodagud@codeaurora.org>
On Wed, Sep 23, 2020 at 05:08:31PM -0700, Prasad Sodagudi wrote:
> During the cpu hot plug stress testing, couple of messages
> continuous flooding on to the console is causing timers
> migration delay. Delayed time migrations from hot plugging
> core is causing device instability with watchdog. So reduce
> log level for couple of prints in cpu hot plug flow.
>
> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
> ---
> arch/arm64/kernel/smp.c | 2 +-
> kernel/irq/cpuhotplug.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 355ee9e..08da6e3 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -338,7 +338,7 @@ void __cpu_die(unsigned int cpu)
> pr_crit("CPU%u: cpu didn't die\n", cpu);
> return;
> }
> - pr_notice("CPU%u: shutdown\n", cpu);
> + pr_info("CPU%u: shutdown\n", cpu);
>
> /*
> * Now that the dying CPU is beyond the point of no return w.r.t.
> diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> index 02236b1..82802e0 100644
> --- a/kernel/irq/cpuhotplug.c
> +++ b/kernel/irq/cpuhotplug.c
> @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
> * If this happens then there was a missed IRQ fixup at some
> * point. Warn about it and enforce fixup.
> */
> - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> + pr_info("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
> cpumask_pr_args(m), d->irq, cpu);
> return true;
> }
> @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
> raw_spin_unlock(&desc->lock);
>
> if (affinity_broken) {
> - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> + pr_info_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> irq, smp_processor_id());
> }
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-09-24 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 0:08 Prasad Sodagudi
2020-09-24 0:08 ` [PATCH 2/2] printk: Make the console flush configurable in hotplug path Prasad Sodagudi
2020-09-24 6:33 ` Greg KH
2020-09-24 18:21 ` Thomas Gleixner
2020-09-25 9:27 ` Greg KH
2020-09-25 14:16 ` Adam Borowski
2020-09-25 22:55 ` Thomas Gleixner
2020-09-28 2:05 ` psodagud
2020-09-28 12:50 ` Greg KH
2020-09-30 14:36 ` Petr Mladek
2020-09-24 6:38 ` Sergey Senozhatsky
2020-09-30 13:57 ` Petr Mladek
2020-09-24 6:31 ` Greg KH [this message]
2020-09-24 18:08 ` [PATCH 1/2] genirq/cpuhotplug: Reduce logging level for couple of prints Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924063152.GA592892@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=psodagud@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
--subject='Re: [PATCH 1/2] genirq/cpuhotplug: Reduce logging level for couple of prints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).