From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8479BC4727D for ; Thu, 24 Sep 2020 19:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B67D2220D for ; Thu, 24 Sep 2020 19:52:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgIXTwC (ORCPT ); Thu, 24 Sep 2020 15:52:02 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:51208 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgIXTwC (ORCPT ); Thu, 24 Sep 2020 15:52:02 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id E71842007A; Thu, 24 Sep 2020 21:51:59 +0200 (CEST) Date: Thu, 24 Sep 2020 21:51:58 +0200 From: Sam Ravnborg To: Yannick Fertre Cc: Philippe Cornu , Antonio Borneo , Thierry Reding , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: otm8009a: remove hack to force commands in HS Message-ID: <20200924195158.GD1223313@ravnborg.org> References: <20200918114718.11106-1-yannick.fertre@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918114718.11106-1-yannick.fertre@st.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=CaYmGojl c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=8b9GpE9nAAAA:8 a=7gkXJVJtAAAA:8 a=3Xn4AMHgg7CwLzf28F8A:9 a=CjuIK1q_8ugA:10 a=T3LWEMljR5ZiDmsYVIUa:22 a=E9Po1WZjFZOl8hwRPBS3:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yannick On Fri, Sep 18, 2020 at 01:47:18PM +0200, Yannick Fertre wrote: > From: Antonio Borneo > > The panel is able to receive commands in LP. The current hack to > force backlight commands in HS was due to workaround an incorrect > settings on DSI controller that prevents sending LP commands while > video out was active. > > Remove the hack that forces HS commands. > > Signed-off-by: Antonio Borneo As Daniel wrote this and the next patch is missing a Signed-off-by: So not applied, but waits for v2 - or that you get commit right and can do it yourself. You can add my: Acked-by: Sam Ravnborg > --- > .../gpu/drm/panel/panel-orisetech-otm8009a.c | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index 6ac1accade80..f80b44a8a700 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -99,20 +99,6 @@ static void otm8009a_dcs_write_buf(struct otm8009a *ctx, const void *data, > dev_warn(ctx->dev, "mipi dsi dcs write buffer failed\n"); > } > > -static void otm8009a_dcs_write_buf_hs(struct otm8009a *ctx, const void *data, > - size_t len) > -{ > - struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - > - /* data will be sent in dsi hs mode (ie. no lpm) */ > - dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > - > - otm8009a_dcs_write_buf(ctx, data, len); > - > - /* restore back the dsi lpm mode */ > - dsi->mode_flags |= MIPI_DSI_MODE_LPM; > -} > - > #define dcs_write_seq(ctx, seq...) \ > ({ \ > static const u8 d[] = { seq }; \ > @@ -400,7 +386,7 @@ static int otm8009a_backlight_update_status(struct backlight_device *bd) > */ > data[0] = MIPI_DCS_SET_DISPLAY_BRIGHTNESS; > data[1] = bd->props.brightness; > - otm8009a_dcs_write_buf_hs(ctx, data, ARRAY_SIZE(data)); > + otm8009a_dcs_write_buf(ctx, data, ARRAY_SIZE(data)); > > /* set Brightness Control & Backlight on */ > data[1] = 0x24; > @@ -412,7 +398,7 @@ static int otm8009a_backlight_update_status(struct backlight_device *bd) > > /* Update Brightness Control & Backlight */ > data[0] = MIPI_DCS_WRITE_CONTROL_DISPLAY; > - otm8009a_dcs_write_buf_hs(ctx, data, ARRAY_SIZE(data)); > + otm8009a_dcs_write_buf(ctx, data, ARRAY_SIZE(data)); > > return 0; > } > -- > 2.17.1