From: Peter Xu <peterx@redhat.com> To: Jason Gunthorpe <jgg@nvidia.com> Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, Christoph Hellwig <hch@lst.de>, Hugh Dickins <hughd@google.com>, Jan Kara <jack@suse.cz>, Jann Horn <jannh@google.com>, John Hubbard <jhubbard@nvidia.com>, Kirill Shutemov <kirill@shutemov.name>, Kirill Tkhai <ktkhai@virtuozzo.com>, Leon Romanovsky <leonro@nvidia.com>, Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>, Oleg Nesterov <oleg@redhat.com> Subject: Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork Date: Fri, 30 Oct 2020 18:52:50 -0400 Message-ID: <20201030225250.GB6357@xz-x1> (raw) In-Reply-To: <2-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.com> Hi, Jason, I think majorly the patch looks good to me, but I have a few pure questions majorly not directly related to the patch itself, but around the contexts. Since I _feel_ like there'll be a new version to update the comments below, maybe I can still ask aloud... Please bare with me. :) On Fri, Oct 30, 2020 at 11:46:21AM -0300, Jason Gunthorpe wrote: > Slow GUP is safe against this race because copy_page_range() is only > called while holding the exclusive side of the mmap_lock on the src > mm_struct. Pure question: I understand that this patch requires this, but... Could anyone remind me why read lock of mmap_sem is not enough for fork() before this one? > > Fixes: f3c64eda3e50 ("mm: avoid early COW write protect games during fork()") > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> > Link: https://lore.kernel.org/r/CAHk-=wi=iCnYCARbPGjkVJu9eyYeZ13N64tZYLdOB8CP5Q_PLw@mail.gmail.com > Reviewed-by: John Hubbard <jhubbard@nvidia.com> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> > --- > arch/x86/kernel/tboot.c | 1 + > drivers/firmware/efi/efi.c | 1 + > include/linux/mm_types.h | 7 +++++++ > kernel/fork.c | 1 + > mm/gup.c | 19 +++++++++++++++++++ > mm/init-mm.c | 1 + > mm/memory.c | 10 +++++++++- > 7 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c > index 992fb1415c0f1f..6a2f542d9588a4 100644 > --- a/arch/x86/kernel/tboot.c > +++ b/arch/x86/kernel/tboot.c > @@ -93,6 +93,7 @@ static struct mm_struct tboot_mm = { > .pgd = swapper_pg_dir, > .mm_users = ATOMIC_INIT(2), > .mm_count = ATOMIC_INIT(1), > + .write_protect_seq = SEQCNT_ZERO(tboot_mm.write_protect_seq), > MMAP_LOCK_INITIALIZER(init_mm) > .page_table_lock = __SPIN_LOCK_UNLOCKED(init_mm.page_table_lock), > .mmlist = LIST_HEAD_INIT(init_mm.mmlist), > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index 5e5480a0a32d7d..2520f6e05f4d44 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -57,6 +57,7 @@ struct mm_struct efi_mm = { > .mm_rb = RB_ROOT, > .mm_users = ATOMIC_INIT(2), > .mm_count = ATOMIC_INIT(1), > + .write_protect_seq = SEQCNT_ZERO(efi_mm.write_protect_seq), > MMAP_LOCK_INITIALIZER(efi_mm) > .page_table_lock = __SPIN_LOCK_UNLOCKED(efi_mm.page_table_lock), > .mmlist = LIST_HEAD_INIT(efi_mm.mmlist), Another pure question: I'm just curious how you find all the statically definied mm_structs, and to make sure all of them are covered (just in case un-initialized seqcount could fail strangely). Actually I'm thinking whether we should have one place to keep all the init vars for all the statically definied mm_structs, so we don't need to find them everytime, but only change that one place. > diff --git a/mm/memory.c b/mm/memory.c > index c48f8df6e50268..294c2c3c4fe00d 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1171,6 +1171,12 @@ copy_page_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma) > mmu_notifier_range_init(&range, MMU_NOTIFY_PROTECTION_PAGE, > 0, src_vma, src_mm, addr, end); > mmu_notifier_invalidate_range_start(&range); > + /* > + * The read side doesn't spin, it goes to the mmap_lock, so the > + * raw version is used to avoid disabling preemption here > + */ > + mmap_assert_write_locked(src_mm); > + raw_write_seqcount_t_begin(&src_mm->write_protect_seq); Would raw_write_seqcount_begin() be better here? My understanding is that we used raw_write_seqcount_t_begin() because we're with spin lock so assuming we disabled preemption already. However I'm thinking whether raw_write_seqcount_begin() would be even better to guarantee that. I have no idea of how the rt kernel merging topic, but if rt kernel merged into mainline then IIUC preemption is allowed here (since pgtable spin lock should be rt_spin_lock, not raw spin locks). An even further pure question on __seqcount_preemptible() (feel free to ignore this question!): I saw that __seqcount_preemptible() seems to have been constantly defined as "return false". Not sure what happened there.. Thanks, -- Peter Xu
next prev parent reply index Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <0-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.com> 2020-10-30 14:46 ` [PATCH v2 1/2] mm: reorganize internal_get_user_pages_fast() Jason Gunthorpe 2020-10-30 16:29 ` Jan Kara 2020-10-30 21:31 ` John Hubbard 2020-10-30 22:36 ` Peter Xu 2020-11-02 22:19 ` [PATCH v2 0/2] Add a seqcount between gup_fast and copy_page_range() Ahmed S. Darwish 2020-11-02 22:39 ` Linus Torvalds 2020-11-02 23:18 ` Ahmed S. Darwish [not found] ` <2-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.com> 2020-10-30 16:51 ` [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork Jan Kara [not found] ` <20201030170226.GF2620339@nvidia.com> 2020-11-02 8:31 ` Jan Kara 2020-10-30 22:52 ` Peter Xu [this message] [not found] ` <20201030235121.GQ2620339@nvidia.com> 2020-10-31 15:26 ` Peter Xu 2020-11-03 0:33 ` Ahmed S. Darwish 2020-11-03 0:17 ` Ahmed S. Darwish [not found] ` <20201103002532.GL2620339@nvidia.com> 2020-11-03 0:41 ` Ahmed S. Darwish 2020-11-03 2:20 ` John Hubbard 2020-11-03 6:52 ` Ahmed S. Darwish 2020-11-03 17:40 ` Linus Torvalds 2020-11-04 1:32 ` Ahmed S. Darwish 2020-11-04 2:01 ` John Hubbard 2020-11-04 3:17 ` Ahmed S. Darwish 2020-11-04 18:38 ` Linus Torvalds 2020-11-04 19:54 ` Ahmed S. Darwish 2020-12-09 18:38 ` [tip: locking/core] seqlock: Prefix internal seqcount_t-only macros with a "do_" tip-bot2 for Ahmed S. Darwish 2020-12-09 18:38 ` [tip: locking/core] seqlock: kernel-doc: Specify when preemption is automatically altered tip-bot2 for Ahmed S. Darwish 2020-11-10 11:53 ` [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork Peter Zijlstra 2020-12-03 10:35 ` [tip: locking/core] seqlock: Rename __seqprop() users tip-bot2 for Peter Zijlstra 2020-11-03 17:03 ` [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork Peter Xu 2020-11-02 23:58 ` Ahmed S. Darwish
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201030225250.GB6357@xz-x1 \ --to=peterx@redhat.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.ibm.com \ --cc=hch@lst.de \ --cc=hughd@google.com \ --cc=jack@suse.cz \ --cc=jannh@google.com \ --cc=jgg@nvidia.com \ --cc=jhubbard@nvidia.com \ --cc=kirill@shutemov.name \ --cc=ktkhai@virtuozzo.com \ --cc=leonro@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=oleg@redhat.com \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git