LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 00/19] scsi: libsas: Remove in_interrupt() check
@ 2021-01-18 10:09 Ahmed S. Darwish
  2021-01-18 10:09 ` [PATCH v3 01/19] Documentation: scsi: libsas: Remove notify_ha_event() Ahmed S. Darwish
                   ` (20 more replies)
  0 siblings, 21 replies; 28+ messages in thread
From: Ahmed S. Darwish @ 2021-01-18 10:09 UTC (permalink / raw)
  To: James E.J. Bottomley, Martin K. Petersen, Christoph Hellwig,
	John Garry, Jason Yan, Daniel Wagner, Artur Paszkiewicz,
	Jack Wang
  Cc: linux-scsi, LKML, Thomas Gleixner, Sebastian A. Siewior,
	Ahmed S. Darwish

Hi,

Changelog v3
------------

- Include latest version of John's patch. Collect r-b tags.

- Limit all code to 80 columns, even for intermediate patches.

- Rebase over v5.11-rc4

Changelog v2
------------

https://lkml.kernel.org/r/20210112110647.627783-1-a.darwish@linutronix.de

- Rebase on top of John's patch "scsi: libsas and users: Remove notifier
  indirection", as it affects every other patch. Include it in this
  series (patch #2).

- Introduce patches #13 => #19, which modify call sites back to use the
  original libsas notifier function names without _gfp() suffix.

- Rebase over v5.11-rc3

v1 / Cover letter
-----------------

https://lkml.kernel.org/r/20201218204354.586951-1-a.darwish@linutronix.de

In the discussion about preempt count consistency across kernel
configurations:

  https://lkml.kernel.org/r/20200914204209.256266093@linutronix.de

it was concluded that the usage of in_interrupt() and related context
checks should be removed from non-core code.

This includes memory allocation mode decisions (GFP_*). In the long run,
usage of in_interrupt() and its siblings should be banned from driver
code completely.

This series addresses SCSI libsas. Basically, the function:

  => drivers/scsi/libsas/sas_init.c:
  struct asd_sas_event *sas_alloc_event(struct asd_sas_phy *phy)
  {
        ...
        gfp_t flags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL;
        event = kmem_cache_zalloc(sas_event_cache, flags);
        ...
  }

is transformed so that callers explicitly pass the gfp_t memory
allocation flags. Affected libsas clients are modified accordingly.

Patches #1, #2 => #7 have "Fixes: " tags and address bugs the were
noticed during the context analysis.

Thanks!

8<--------------

Ahmed S. Darwish (18):
  Documentation: scsi: libsas: Remove notify_ha_event()
  scsi: libsas: Introduce a _gfp() variant of event notifiers
  scsi: mvsas: Pass gfp_t flags to libsas event notifiers
  scsi: isci: port: link down: Pass gfp_t flags
  scsi: isci: port: link up: Pass gfp_t flags
  scsi: isci: port: broadcast change: Pass gfp_t flags
  scsi: libsas: Pass gfp_t flags to event notifiers
  scsi: pm80xx: Pass gfp_t flags to libsas event notifiers
  scsi: aic94xx: Pass gfp_t flags to libsas event notifiers
  scsi: hisi_sas: Pass gfp_t flags to libsas event notifiers
  scsi: libsas: event notifiers API: Add gfp_t flags parameter
  scsi: hisi_sas: Switch back to original libsas event notifiers
  scsi: aic94xx: Switch back to original libsas event notifiers
  scsi: pm80xx: Switch back to original libsas event notifiers
  scsi: libsas: Switch back to original event notifiers API
  scsi: isci: Switch back to original libsas event notifiers
  scsi: mvsas: Switch back to original libsas event notifiers
  scsi: libsas: Remove temporarily-added _gfp() API variants

John Garry (1):
  scsi: libsas and users: Remove notifier indirection

 Documentation/scsi/libsas.rst          |  9 +----
 drivers/scsi/aic94xx/aic94xx_scb.c     | 24 ++++++------
 drivers/scsi/hisi_sas/hisi_sas.h       |  3 +-
 drivers/scsi/hisi_sas/hisi_sas_main.c  | 29 +++++++-------
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c |  7 ++--
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  7 ++--
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  7 ++--
 drivers/scsi/isci/port.c               | 11 +++---
 drivers/scsi/libsas/sas_event.c        | 27 ++++++-------
 drivers/scsi/libsas/sas_init.c         | 19 ++++-----
 drivers/scsi/libsas/sas_internal.h     |  6 +--
 drivers/scsi/mvsas/mv_sas.c            | 25 ++++++------
 drivers/scsi/pm8001/pm8001_hwi.c       | 54 ++++++++++++++++----------
 drivers/scsi/pm8001/pm8001_sas.c       | 12 ++----
 drivers/scsi/pm8001/pm80xx_hwi.c       | 46 ++++++++++++----------
 include/scsi/libsas.h                  |  9 +++--
 16 files changed, 149 insertions(+), 146 deletions(-)

base-commit: 19c329f6808995b142b3966301f217c831e7cf31
--
2.30.0

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 02/19] scsi: libsas and users: Remove notifier indirection
@ 2021-01-12 11:36 John Garry
  2021-01-12 13:07 ` [PATCH v3 " Ahmed S. Darwish
  0 siblings, 1 reply; 28+ messages in thread
From: John Garry @ 2021-01-12 11:36 UTC (permalink / raw)
  To: Ahmed S. Darwish, James E.J. Bottomley, Martin K. Petersen,
	Jason Yan, Daniel Wagner, Artur Paszkiewicz, Jack Wang
  Cc: linux-scsi, intel-linux-scu, LKML, Thomas Gleixner, Sebastian A. Siewior

On 12/01/2021 11:06, Ahmed S. Darwish wrote:
> From: John Garry<john.garry@huawei.com>
> 
> The LLDDs report events to libsas with .notify_port_event and
> .notify_phy_event callbacks.
> 
> These callbacks are fixed and so there is no reason why we cannot call the
> functions directly, so do that.
> 
> This neatens the code slightly.
> 
> [a.darwish@linutronix.de: Remove the now unused "sas_ha" local variables]
> Signed-off-by: John Garry<john.garry@huawei.com>

Don't forget your signed-off-by :)

> ---
>   Documentation/scsi/libsas.rst          |  4 +--
>   drivers/scsi/aic94xx/aic94xx_scb.c     | 20 ++++++-------
>   drivers/scsi/hisi_sas/hisi_sas_main.c  | 12 +++-----
>   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c |  3 +-
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  3 +-
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  3 +-
>   drivers/scsi/isci/port.c               |  7 ++---
>   drivers/scsi/libsas/sas_event.c        | 13 +++------
>   drivers/scsi/libsas/sas_init.c         |  6 ----
>   drivers/scsi/libsas/sas_internal.h     |  1 -
>   drivers/scsi/mvsas/mv_sas.c            | 14 ++++-----
>   drivers/scsi/pm8001/pm8001_hwi.c       | 40 ++++++++++++--------------
>   drivers/scsi/pm8001/pm8001_sas.c       |  7 ++---
>   drivers/scsi/pm8001/pm80xx_hwi.c       | 35 ++++++++++------------
>   include/scsi/libsas.h                  |  7 ++---
>   15 files changed, 69 insertions(+), 106 deletions(-)
> 
> diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
> index f9b77c7879db..a183b1d84713 100644
> --- a/Documentation/scsi/libsas.rst
> +++ b/Documentation/scsi/libsas.rst
> @@ -189,8 +189,8 @@ num_phys
>   The event interface::
>   
>   	/* LLDD calls these to notify the class of an event. */
> -	void (*notify_port_event)(struct sas_phy *, enum port_event);
> -	void (*notify_phy_event)(struct sas_phy *, enum phy_event);
> +	void sas_notify_port_event(struct sas_phy *, enum port_event);
> +	void sas_notify_phy_event(struct sas_phy *, enum phy_event);
>   
>   When sas_register_ha() returns, those are set and can be
>   called by the LLDD to notify the SAS layer of such events

Maybe this was missed in the rebase, but I think that this comment can 
go/be changed at some stage.

Thanks,
John

^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2021-01-27  5:26 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 10:09 [PATCH v3 00/19] scsi: libsas: Remove in_interrupt() check Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 01/19] Documentation: scsi: libsas: Remove notify_ha_event() Ahmed S. Darwish
2021-01-18 10:22   ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 02/19] scsi: libsas and users: Remove notifier indirection Ahmed S. Darwish
2021-01-18 10:26   ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 03/19] scsi: libsas: Introduce a _gfp() variant of event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 04/19] scsi: mvsas: Pass gfp_t flags to libsas " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 05/19] scsi: isci: port: link down: Pass gfp_t flags Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 06/19] scsi: isci: port: link up: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 07/19] scsi: isci: port: broadcast change: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 08/19] scsi: libsas: Pass gfp_t flags to event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 09/19] scsi: pm80xx: Pass gfp_t flags to libsas " Ahmed S. Darwish
2021-01-18 10:26   ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 10/19] scsi: aic94xx: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 11/19] scsi: hisi_sas: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 12/19] scsi: libsas: event notifiers API: Add gfp_t flags parameter Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 13/19] scsi: hisi_sas: Switch back to original libsas event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 14/19] scsi: aic94xx: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 15/19] scsi: pm80xx: " Ahmed S. Darwish
2021-01-18 10:27   ` Jinpu Wang
2021-01-18 10:09 ` [PATCH v3 16/19] scsi: libsas: Switch back to original event notifiers API Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 17/19] scsi: isci: Switch back to original libsas event notifiers Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 18/19] scsi: mvsas: " Ahmed S. Darwish
2021-01-18 10:09 ` [PATCH v3 19/19] scsi: libsas: Remove temporarily-added _gfp() API variants Ahmed S. Darwish
2021-01-23  2:32 ` [PATCH v3 00/19] scsi: libsas: Remove in_interrupt() check Martin K. Petersen
2021-01-27  4:54 ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2021-01-12 11:36 [PATCH v2 02/19] scsi: libsas and users: Remove notifier indirection John Garry
2021-01-12 13:07 ` [PATCH v3 " Ahmed S. Darwish
2021-01-12 15:43   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox