LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells
@ 2021-03-12  6:28 Ansuel Smith
  2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Ansuel Smith @ 2021-03-12  6:28 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Ansuel Smith, Rafał Miłecki, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Rob Herring,
	Srinivas Kandagatla, linux-mtd, devicetree, linux-kernel

Partitions that contains the nvmem-cells compatible will register
their direct subonodes as nvmem cells and the node will be treated as a
nvmem provider.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Tested-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/mtd/mtdcore.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 2d6423d89a17..ac1b4f176a17 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -531,6 +531,7 @@ static int mtd_nvmem_reg_read(void *priv, unsigned int offset,
 
 static int mtd_nvmem_add(struct mtd_info *mtd)
 {
+	struct device_node *node = mtd_get_of_node(mtd);
 	struct nvmem_config config = {};
 
 	config.id = -1;
@@ -543,7 +544,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
 	config.stride = 1;
 	config.read_only = true;
 	config.root_only = true;
-	config.no_of_node = true;
+	config.no_of_node = !of_device_is_compatible(node, "nvmem-cells");
 	config.priv = mtd;
 
 	mtd->nvmem = nvmem_register(&config);
-- 
2.30.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction
  2021-03-12  6:28 [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
@ 2021-03-12  6:28 ` Ansuel Smith
  2021-03-22 17:36   ` Rob Herring
  2021-03-28 17:28   ` Miquel Raynal
  2021-03-12  6:28 ` [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
  2021-03-28 17:28 ` [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Miquel Raynal
  2 siblings, 2 replies; 7+ messages in thread
From: Ansuel Smith @ 2021-03-12  6:28 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Ansuel Smith, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Srinivas Kandagatla, linux-mtd,
	devicetree, linux-kernel

Drop $nodename restriction as now mtd partition can also be used as
nvmem provider.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
index 7481a9e48f19..b8dc3d2b6e92 100644
--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
@@ -20,9 +20,6 @@ description: |
   storage device.
 
 properties:
-  $nodename:
-    pattern: "^(eeprom|efuse|nvram)(@.*|-[0-9a-f])*$"
-
   "#address-cells":
     const: 1
 
-- 
2.30.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible
  2021-03-12  6:28 [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
  2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
@ 2021-03-12  6:28 ` Ansuel Smith
  2021-03-28 17:28   ` Miquel Raynal
  2021-03-28 17:28 ` [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Miquel Raynal
  2 siblings, 1 reply; 7+ messages in thread
From: Ansuel Smith @ 2021-03-12  6:28 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Ansuel Smith, Rob Herring, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Srinivas Kandagatla, linux-mtd,
	devicetree, linux-kernel

Document nvmem-cells compatible used to treat mtd partitions as a
nvmem provider.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../bindings/mtd/partitions/nvmem-cells.yaml  | 99 +++++++++++++++++++
 1 file changed, 99 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml

diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
new file mode 100644
index 000000000000..5cdd2efa9132
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nvmem cells
+
+description: |
+  Any partition containing the compatible "nvmem-cells" will register as a
+  nvmem provider.
+  Each direct subnodes represents a nvmem cell following the nvmem binding.
+  Nvmem binding to declare nvmem-cells can be found in:
+  Documentation/devicetree/bindings/nvmem/nvmem.yaml
+
+maintainers:
+  - Ansuel Smith <ansuelsmth@gmail.com>
+
+allOf:
+  - $ref: /schemas/nvmem/nvmem.yaml#
+
+properties:
+  compatible:
+    const: nvmem-cells
+
+required:
+  - compatible
+
+additionalProperties: true
+
+examples:
+  - |
+    partitions {
+      compatible = "fixed-partitions";
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      /* ... */
+
+      };
+      art: art@1200000 {
+        compatible = "nvmem-cells";
+        reg = <0x1200000 0x0140000>;
+        label = "art";
+        read-only;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        macaddr_gmac1: macaddr_gmac1@0 {
+          reg = <0x0 0x6>;
+        };
+
+        macaddr_gmac2: macaddr_gmac2@6 {
+          reg = <0x6 0x6>;
+        };
+
+        pre_cal_24g: pre_cal_24g@1000 {
+          reg = <0x1000 0x2f20>;
+        };
+
+        pre_cal_5g: pre_cal_5g@5000{
+          reg = <0x5000 0x2f20>;
+        };
+      };
+  - |
+    partitions {
+        compatible = "fixed-partitions";
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        partition@0 {
+            label = "bootloader";
+            reg = <0x000000 0x100000>;
+            read-only;
+        };
+
+        firmware@100000 {
+            compatible = "brcm,trx";
+            label = "firmware";
+            reg = <0x100000 0xe00000>;
+        };
+
+        calibration@f00000 {
+            compatible = "nvmem-cells";
+            label = "calibration";
+            reg = <0xf00000 0x100000>;
+            ranges = <0 0xf00000 0x100000>;
+            #address-cells = <1>;
+            #size-cells = <1>;
+
+            wifi0@0 {
+                reg = <0x000000 0x080000>;
+            };
+
+            wifi1@80000 {
+                reg = <0x080000 0x080000>;
+            };
+        };
+    };
-- 
2.30.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction
  2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
@ 2021-03-22 17:36   ` Rob Herring
  2021-03-28 17:28   ` Miquel Raynal
  1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-03-22 17:36 UTC (permalink / raw)
  To: Ansuel Smith
  Cc: Richard Weinberger, Rob Herring, Miquel Raynal, devicetree,
	Rafał Miłecki, Srinivas Kandagatla, linux-mtd,
	linux-kernel, Vignesh Raghavendra

On Fri, 12 Mar 2021 07:28:20 +0100, Ansuel Smith wrote:
> Drop $nodename restriction as now mtd partition can also be used as
> nvmem provider.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
>  Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 ---
>  1 file changed, 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible
  2021-03-12  6:28 ` [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
@ 2021-03-28 17:28   ` Miquel Raynal
  0 siblings, 0 replies; 7+ messages in thread
From: Miquel Raynal @ 2021-03-28 17:28 UTC (permalink / raw)
  To: Ansuel Smith, Rafał Miłecki
  Cc: Miquel Raynal, Rob Herring, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Srinivas Kandagatla, linux-mtd,
	devicetree, linux-kernel

On Fri, 2021-03-12 at 06:28:21 UTC, Ansuel Smith wrote:
> Document nvmem-cells compatible used to treat mtd partitions as a
> nvmem provider.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction
  2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
  2021-03-22 17:36   ` Rob Herring
@ 2021-03-28 17:28   ` Miquel Raynal
  1 sibling, 0 replies; 7+ messages in thread
From: Miquel Raynal @ 2021-03-28 17:28 UTC (permalink / raw)
  To: Ansuel Smith, Rafał Miłecki
  Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
	Rob Herring, Srinivas Kandagatla, linux-mtd, devicetree,
	linux-kernel

On Fri, 2021-03-12 at 06:28:20 UTC, Ansuel Smith wrote:
> Drop $nodename restriction as now mtd partition can also be used as
> nvmem provider.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells
  2021-03-12  6:28 [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
  2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
  2021-03-12  6:28 ` [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
@ 2021-03-28 17:28 ` Miquel Raynal
  2 siblings, 0 replies; 7+ messages in thread
From: Miquel Raynal @ 2021-03-28 17:28 UTC (permalink / raw)
  To: Ansuel Smith, Rafał Miłecki
  Cc: Miquel Raynal, Rafał Miłecki, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Srinivas Kandagatla, linux-mtd,
	devicetree, linux-kernel

On Fri, 2021-03-12 at 06:28:19 UTC, Ansuel Smith wrote:
> Partitions that contains the nvmem-cells compatible will register
> their direct subonodes as nvmem cells and the node will be treated as a
> nvmem provider.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Tested-by: Rafał Miłecki <rafal@milecki.pl>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-03-28 17:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12  6:28 [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
2021-03-12  6:28 ` [PATCH v7 2/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
2021-03-22 17:36   ` Rob Herring
2021-03-28 17:28   ` Miquel Raynal
2021-03-12  6:28 ` [PATCH v7 3/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
2021-03-28 17:28   ` Miquel Raynal
2021-03-28 17:28 ` [PATCH v7 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).