From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5C6C433E6 for ; Sat, 13 Mar 2021 15:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98A7864F16 for ; Sat, 13 Mar 2021 15:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233841AbhCMPP6 (ORCPT ); Sat, 13 Mar 2021 10:15:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:32844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbhCMPPY (ORCPT ); Sat, 13 Mar 2021 10:15:24 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10A9864F16; Sat, 13 Mar 2021 15:15:21 +0000 (UTC) Date: Sat, 13 Mar 2021 15:15:18 +0000 From: Jonathan Cameron To: Oleksij Rempel Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , David Jander , Robin van der Gracht , linux-iio@vger.kernel.org, Lars-Peter Clausen , Peter Meerwald-Stadler , Dmitry Torokhov Subject: Re: [PATCH v2 1/3] dt-bindings:iio:adc: add generic settling-time-us and average-samples channel properties Message-ID: <20210313151518.2681a59a@archlinux> In-Reply-To: <20210312105515.32055-2-o.rempel@pengutronix.de> References: <20210312105515.32055-1-o.rempel@pengutronix.de> <20210312105515.32055-2-o.rempel@pengutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Mar 2021 11:55:13 +0100 Oleksij Rempel wrote: > Settling time and over sampling is a typical challenge for different IIO ADC > devices. So, introduce channel specific settling-time-us and average-samples > properties to cover this use case. > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/iio/adc/adc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml > index 912a7635edc4..c748f6573027 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml > @@ -39,4 +39,13 @@ properties: > The first value specifies the positive input pin, the second > specifies the negative input pin. > > + settling-time-us: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Time between enabling the channel and firs stable readings. first > + > + average-samples: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Number of data samples which are averaged for each read. So in IIO at least, we tend to refer to this as oversampling. Perhaps we should use that term here as well? It would also be good to give some hint as to why this might be a DT property rather than a userspace control. Thanks, Jonathan > + > additionalProperties: true