LKML Archive on
help / color / mirror / Atom feed
From: Colin King <>
To: Pavel Machek <>,
Subject: [PATCH] leds: flash: Remove redundant initialization of variable ret
Date: Sat, 12 Jun 2021 14:25:47 +0100	[thread overview]
Message-ID: <> (raw)

From: Colin Ian King <>

The variable ret is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <>
 drivers/leds/led-class-flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6eeb9effcf65..e4c4fd97bf30 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -92,7 +92,7 @@ static ssize_t flash_strobe_store(struct device *dev,
 	struct led_classdev *led_cdev = dev_get_drvdata(dev);
 	struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
 	unsigned long state;
-	ssize_t ret = -EINVAL;
+	ssize_t ret;

             reply	other threads:[~2021-06-12 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 13:25 Colin King [this message]
2021-08-16  6:51 ` [PATCH] leds: flash: Remove redundant initialization of variable ret Pavel Machek
2021-08-16  7:55   ` Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).