LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@surriel.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <valentin.schneider@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v2 2/2] powerpc/numa: Fill distance_lookup_table for offline nodes
Date: Thu, 1 Jul 2021 17:36:08 +0800 [thread overview]
Message-ID: <202107011711.U4wyE3KW-lkp@intel.com> (raw)
In-Reply-To: <20210701041552.112072-3-srikar@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3856 bytes --]
Hi Srikar,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 031e3bd8986fffe31e1ddbf5264cccfe30c9abd7]
url: https://github.com/0day-ci/linux/commits/Srikar-Dronamraju/Skip-numa-distance-for-offline-nodes/20210701-121809
base: 031e3bd8986fffe31e1ddbf5264cccfe30c9abd7
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/715881c25ce171cc9d097d4faeb0dce60bb3e71c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srikar-Dronamraju/Skip-numa-distance-for-offline-nodes/20210701-121809
git checkout 715881c25ce171cc9d097d4faeb0dce60bb3e71c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/powerpc/mm/numa.c:871:13: warning: no previous prototype for 'fake_update_distance_lookup_table' [-Wmissing-prototypes]
871 | void __init fake_update_distance_lookup_table(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/fake_update_distance_lookup_table +871 arch/powerpc/mm/numa.c
862
863 /*
864 * Scheduler expects unique number of node distances to be available at
865 * boot. It uses node distance to calculate this unique node distances. On
866 * POWER, node distances for offline nodes is not available. However, POWER
867 * already knows unique possible node distances. Fake the offline node's
868 * distance_lookup_table entries so that all possible node distances are
869 * updated.
870 */
> 871 void __init fake_update_distance_lookup_table(void)
872 {
873 unsigned long distance_map;
874 int i, nr_levels, nr_depth, node;
875
876 if (!numa_enabled)
877 return;
878
879 if (!form1_affinity)
880 return;
881
882 /*
883 * distance_ref_points_depth lists the unique numa domains
884 * available. However it ignore LOCAL_DISTANCE. So add +1
885 * to get the actual number of unique distances.
886 */
887 nr_depth = distance_ref_points_depth + 1;
888
889 WARN_ON(nr_depth > sizeof(distance_map));
890
891 bitmap_zero(&distance_map, nr_depth);
892 bitmap_set(&distance_map, 0, 1);
893
894 for_each_online_node(node) {
895 int nd, distance = LOCAL_DISTANCE;
896
897 if (node == first_online_node)
898 continue;
899
900 nd = __node_distance(node, first_online_node);
901 for (i = 0; i < nr_depth; i++, distance *= 2) {
902 if (distance == nd) {
903 bitmap_set(&distance_map, i, 1);
904 break;
905 }
906 }
907 nr_levels = bitmap_weight(&distance_map, nr_depth);
908 if (nr_levels == nr_depth)
909 return;
910 }
911
912 for_each_node(node) {
913 if (node_online(node))
914 continue;
915
916 i = find_first_zero_bit(&distance_map, nr_depth);
917 if (i >= nr_depth || i == 0) {
918 pr_warn("Levels(%d) not matching levels(%d)", nr_levels, nr_depth);
919 return;
920 }
921
922 bitmap_set(&distance_map, i, 1);
923 while (i--)
924 distance_lookup_table[node][i] = node;
925
926 nr_levels = bitmap_weight(&distance_map, nr_depth);
927 if (nr_levels == nr_depth)
928 return;
929 }
930 }
931
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73418 bytes --]
next prev parent reply other threads:[~2021-07-01 9:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 4:15 [PATCH v2 0/2] Skip numa distance for offline nodes Srikar Dronamraju
2021-07-01 4:15 ` [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes Srikar Dronamraju
2021-07-01 14:28 ` Valentin Schneider
2021-07-12 12:48 ` Srikar Dronamraju
2021-07-13 16:32 ` Valentin Schneider
2021-07-23 14:39 ` Srikar Dronamraju
2021-08-04 10:01 ` Srikar Dronamraju
2021-08-04 10:20 ` Valentin Schneider
2021-08-08 15:56 ` Valentin Schneider
2021-08-09 6:52 ` Srikar Dronamraju
2021-08-09 12:52 ` Valentin Schneider
2021-08-10 11:47 ` Srikar Dronamraju
2021-08-16 10:33 ` Srikar Dronamraju
2021-08-17 0:01 ` Valentin Schneider
2021-07-01 4:15 ` [PATCH v2 2/2] powerpc/numa: Fill distance_lookup_table for offline nodes Srikar Dronamraju
2021-07-01 9:36 ` kernel test robot [this message]
2021-07-01 10:20 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107011711.U4wyE3KW-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).