LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org> To: LKML <linux-kernel@vger.kernel.org> Cc: Frederic Weisbecker <frederic@kernel.org>, Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, Alex Belits <abelits@marvell.com>, Nitesh Lal <nilal@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Nicolas Saenz <nsaenzju@redhat.com>, Christoph Lameter <cl@gentwo.de>, Marcelo Tosatti <mtosatti@redhat.com>, Zefan Li <lizefan.x@bytedance.com>, cgroups@vger.kernel.org Subject: [RFC PATCH 5/6] sched/isolation: Make HK_FLAG_DOMAIN mutable Date: Wed, 14 Jul 2021 15:54:19 +0200 [thread overview] Message-ID: <20210714135420.69624-6-frederic@kernel.org> (raw) In-Reply-To: <20210714135420.69624-1-frederic@kernel.org> In order to prepare supporting "isolcpus=" changes toward cpuset, provide an API to modify the "isolcpus=" cpumask passed on boot. TODO: * Propagate the change to all interested subsystems (workqueue, net, pci) * Make sure we can't concurrently change this cpumask (assert cpuset_rwsem is held). Signed-off-by: Frederic Weisbecker <frederic@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Juri Lelli <juri.lelli@redhat.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Nitesh Lal <nilal@redhat.com> Cc: Nicolas Saenz <nsaenzju@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Lameter <cl@gentwo.de> Cc: Tejun Heo <tj@kernel.org> Cc: Zefan Li <lizefan.x@bytedance.com> Cc: Alex Belits <abelits@marvell.com> --- include/linux/sched/isolation.h | 4 ++++ kernel/sched/isolation.c | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h index cc9f393e2a70..a5960cb357d2 100644 --- a/include/linux/sched/isolation.h +++ b/include/linux/sched/isolation.h @@ -21,6 +21,7 @@ enum hk_flags { DECLARE_STATIC_KEY_FALSE(housekeeping_overridden); extern int housekeeping_any_cpu(enum hk_flags flags); extern const struct cpumask *housekeeping_cpumask(enum hk_flags flags); +extern void housekeeping_cpumask_set(struct cpumask *mask, enum hk_flags flags); extern bool housekeeping_enabled(enum hk_flags flags); extern void housekeeping_affine(struct task_struct *t, enum hk_flags flags); extern bool housekeeping_test_cpu(int cpu, enum hk_flags flags); @@ -38,6 +39,9 @@ static inline const struct cpumask *housekeeping_cpumask(enum hk_flags flags) return cpu_possible_mask; } +static inline void housekeeping_cpumask_set(struct cpumask *mask, + enum hk_flags flags) { } + static inline bool housekeeping_enabled(enum hk_flags flags) { return false; diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c index c2bdf7e6dc39..c071433059cf 100644 --- a/kernel/sched/isolation.c +++ b/kernel/sched/isolation.c @@ -68,7 +68,26 @@ bool housekeeping_test_cpu(int cpu, enum hk_flags flags) } EXPORT_SYMBOL_GPL(housekeeping_test_cpu); +// Only support HK_FLAG_DOMAIN for now +// TODO: propagate the changes through all interested subsystems: +// workqueues, net, pci; ... +void housekeeping_cpumask_set(struct cpumask *mask, enum hk_flags flags) +{ + /* Only HK_FLAG_DOMAIN change supported for now */ + if (WARN_ON_ONCE(flags != HK_FLAG_DOMAIN)) + return; + if (!static_key_enabled(&housekeeping_overridden.key)) { + if (cpumask_equal(mask, cpu_possible_mask)) + return; + if (WARN_ON_ONCE(!alloc_cpumask_var(&hk_domain_mask, GFP_KERNEL))) + return; + cpumask_copy(hk_domain_mask, mask); + static_branch_enable(&housekeeping_overridden); + } else { + cpumask_copy(hk_domain_mask, mask); + } +} void __init housekeeping_init(void) { -- 2.25.1
next prev parent reply other threads:[~2021-07-14 13:54 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-14 13:54 [RFC PATCH 0/6] cpuset: Allow to modify isolcpus through cpuset Frederic Weisbecker 2021-07-14 13:54 ` [RFC PATCH 1/6] pci: Decouple HK_FLAG_WQ and HK_FLAG_DOMAIN cpumask fetch Frederic Weisbecker 2021-07-14 13:54 ` [RFC PATCH 2/6] workqueue: " Frederic Weisbecker 2021-07-14 13:54 ` [RFC PATCH 3/6] net: " Frederic Weisbecker 2021-07-14 13:54 ` [RFC PATCH 4/6] sched/isolation: Split domain housekeeping mask from the rest Frederic Weisbecker 2021-07-14 13:54 ` Frederic Weisbecker [this message] 2021-07-21 14:28 ` [RFC PATCH 5/6] sched/isolation: Make HK_FLAG_DOMAIN mutable Vincent Donnefort 2021-07-14 13:54 ` [RFC PATCH 6/6] cpuset: Add cpuset.isolation_mask file Frederic Weisbecker 2021-07-14 16:31 ` Marcelo Tosatti 2021-07-19 13:26 ` Frederic Weisbecker 2021-07-19 15:41 ` Marcelo Tosatti 2021-07-14 16:52 ` Peter Zijlstra 2021-07-14 23:13 ` Frederic Weisbecker 2021-07-14 23:44 ` Valentin Schneider 2021-07-15 0:07 ` Frederic Weisbecker 2021-07-15 9:04 ` Peter Zijlstra 2021-07-19 13:17 ` Frederic Weisbecker 2021-07-16 18:02 ` [RFC PATCH 0/6] cpuset: Allow to modify isolcpus through cpuset Waiman Long 2021-07-19 13:57 ` Frederic Weisbecker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210714135420.69624-6-frederic@kernel.org \ --to=frederic@kernel.org \ --cc=abelits@marvell.com \ --cc=cgroups@vger.kernel.org \ --cc=cl@gentwo.de \ --cc=juri.lelli@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan.x@bytedance.com \ --cc=mtosatti@redhat.com \ --cc=nilal@redhat.com \ --cc=nsaenzju@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).