LKML Archive on
help / color / mirror / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	kernel test robot <>,
	Dongjiu Geng <>,
	Stephen Boyd <>,,,
	Michael Turquette <>
Subject: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
Date: Fri, 16 Jul 2021 21:31:59 -0700	[thread overview]
Message-ID: <> (raw)

The clk-hi3559a driver uses functions from reset.c so it should
select RESET_HISI to avoid build errors.

Fixes these build errors:
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'

Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: Randy Dunlap <>
Reported-by: kernel test robot <>
Cc: Dongjiu Geng <>
Cc: Stephen Boyd <>
Cc: Michael Turquette <>
 drivers/clk/hisilicon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
+++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
@@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
 config COMMON_CLK_HI3559A
 	bool "Hi3559A Clock Driver"
 	depends on ARCH_HISI || COMPILE_TEST
+	select RESET_HISI
 	default ARCH_HISI
 	  Build the clock driver for hi3559a.

             reply	other threads:[~2021-07-17  4:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17  4:31 Randy Dunlap [this message]
2021-07-19  2:55 ` Dongjiu Geng
2021-07-27  0:23 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).