LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
Date: Tue, 20 Jul 2021 09:39:59 -0500	[thread overview]
Message-ID: <20210720143959.6zmfo6pmrkpzkpse@repaint> (raw)
In-Reply-To: <f3560ac8-8ffe-87d6-a21f-87f6251f1750@ti.com>

On 20:00-20210720, Aswath Govindraju wrote:
> Hi Marc,
> 
> On 20/07/21 7:50 pm, Marc Kleine-Budde wrote:
> > On 20.07.2021 19:46:37, Aswath Govindraju wrote:
> >> From: Faiz Abbas <faiz_abbas@ti.com>
> >>
> >> Add Support for two MCAN controllers present on the am65x SOC. Both support
> >> classic CAN messages as well as CAN-FD.
> > 
> > Thanks for the patch!
> > 
> > Why don't you disable the CAN cores by default in the dtsi?
> 
> As far as I know, in the dtsi file we mention all the subsystems or
> periherals present in the SoC and in the specific board dts file we
> enable or disable the DT nodes depending on whether the  pins are
> brought out.


There is a long history on this. You should be able to look the
discussion up in lore archives. The nutshell is the dtsi files should
maintain DT standard which is "default, status if not explicitly
provided is enabled" and the board dts files will explicitly disable
OR reserve the nodes that are not pinned out / used / reserved (due to
firmware usage) etc. There is the entire string parsing, size arguments
that run around this topic, but, anyways.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2021-07-20 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 14:16 [PATCH 0/6] CAN: Add support for CAN in AM65,J721e and AM64 Aswath Govindraju
2021-07-20 14:16 ` [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN Aswath Govindraju
2021-07-20 14:20   ` Marc Kleine-Budde
2021-07-20 14:30     ` Aswath Govindraju
2021-07-20 14:39       ` Nishanth Menon [this message]
2021-07-20 14:49       ` Marc Kleine-Budde
2021-07-20 14:16 ` [PATCH 2/6] arm64: dts: ti: am654-base-board: Disable mcan nodes Aswath Govindraju
2021-07-20 14:16 ` [PATCH 3/6] arm64: dts: ti: k3-j721e: Add support for MCAN nodes Aswath Govindraju
2021-07-20 14:54   ` Marc Kleine-Budde
2021-07-21  7:48     ` Aswath Govindraju
2021-07-26  7:43       ` Aswath Govindraju
2021-07-20 14:16 ` [PATCH 4/6] arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan nodes Aswath Govindraju
2021-07-20 14:16 ` [PATCH 5/6] arm64: dts: ti: k3-am64-main: Add support for MCAN Aswath Govindraju
2021-07-20 14:16 ` [PATCH 6/6] arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan nodes in EVM and disable them on SK Aswath Govindraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720143959.6zmfo6pmrkpzkpse@repaint \
    --to=nm@ti.com \
    --cc=a-govindraju@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=mkl@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).