LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] sched: remove redundant on_rq status change
@ 2021-07-21  9:11 Wang Hui
  2021-08-05  9:34 ` [tip: sched/core] " tip-bot2 for Wang Hui
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Hui @ 2021-07-21  9:11 UTC (permalink / raw)
  To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
	rostedt, bsegall, mgorman, bristot
  Cc: linux-kernel

activate_task/deactivate_task will change on_rq status,
no need to do it again.

Signed-off-by: Wang Hui <john.wanghui@huawei.com>
---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 014ce8b385c7..a0c35da186d0 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5679,11 +5679,9 @@ static bool try_steal_cookie(int this, int that)
 		if (p->core_occupation > dst->idle->core_occupation)
 			goto next;
 
-		p->on_rq = TASK_ON_RQ_MIGRATING;
 		deactivate_task(src, p, 0);
 		set_task_cpu(p, this);
 		activate_task(dst, p, 0);
-		p->on_rq = TASK_ON_RQ_QUEUED;
 
 		resched_curr(dst);
 
-- 
2.29.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip: sched/core] sched: remove redundant on_rq status change
  2021-07-21  9:11 [PATCH -next] sched: remove redundant on_rq status change Wang Hui
@ 2021-08-05  9:34 ` tip-bot2 for Wang Hui
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Wang Hui @ 2021-08-05  9:34 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Wang Hui, Peter Zijlstra (Intel), x86, linux-kernel

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     f912d051619d11411867f642d2004928eb0b41b1
Gitweb:        https://git.kernel.org/tip/f912d051619d11411867f642d2004928eb0b41b1
Author:        Wang Hui <john.wanghui@huawei.com>
AuthorDate:    Wed, 21 Jul 2021 17:11:09 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 04 Aug 2021 15:16:43 +02:00

sched: remove redundant on_rq status change

activate_task/deactivate_task will change on_rq status,
no need to do it again.

Signed-off-by: Wang Hui <john.wanghui@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210721091109.1406043-1-john.wanghui@huawei.com
---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0c22cd0..6c562ad 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5659,11 +5659,9 @@ static bool try_steal_cookie(int this, int that)
 		if (p->core_occupation > dst->idle->core_occupation)
 			goto next;
 
-		p->on_rq = TASK_ON_RQ_MIGRATING;
 		deactivate_task(src, p, 0);
 		set_task_cpu(p, this);
 		activate_task(dst, p, 0);
-		p->on_rq = TASK_ON_RQ_QUEUED;
 
 		resched_curr(dst);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05  9:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21  9:11 [PATCH -next] sched: remove redundant on_rq status change Wang Hui
2021-08-05  9:34 ` [tip: sched/core] " tip-bot2 for Wang Hui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).