LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: imx8mp: Add dsp node
@ 2021-07-16 12:47 Daniel Baluta
  2021-07-16 16:07 ` Iuliana Prodan
  2021-07-23  8:02 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Baluta @ 2021-07-16 12:47 UTC (permalink / raw)
  To: robh+dt, shawnguo
  Cc: s.hauer, kernel, festevam, linux-imx, qiangqing.zhang, ping.bai,
	alice.guo, jun.li, peng.fan, thunder.leizhen, yibin.gong,
	devicetree, linux-arm-kernel, linux-kernel, Daniel Baluta

From: Daniel Baluta <daniel.baluta@nxp.com>

i.MX8 MPlus SoC integrates Cadence HIFI4 DSP. This core runs either a
custom firmware or the open source SOF firmware [1]

DSP device is handled by SOF OF driver found in
sound/soc/sof/sof-of-dev.c

Notice that the DSP node makes use of:
	- dsp_reserved, a reserved memory region for various Audio
	  resources (e.g firmware loading, audio buffers, etc).
	- Messaging Unit (mu2) for passing notifications betweem ARM
	  core and DSP.

[1] https://thesofproject.github.io/latest/platforms/index.html
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
Changes since v1:
	* mark MU2 node as disabled, because mu2 clock support is not yet upstream.

 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 29 +++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9f7c7f587d38..fb0ac85c8473 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -135,6 +135,17 @@ clk_ext4: clock-ext4 {
 		clock-output-names = "clk_ext4";
 	};
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		dsp_reserved: dsp@92400000 {
+			reg = <0 0x92400000 0 0x2000000>;
+			no-map;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a53-pmu";
 		interrupts = <GIC_PPI 7
@@ -698,6 +709,14 @@ mu: mailbox@30aa0000 {
 				#mbox-cells = <2>;
 			};
 
+			mu2: mailbox@30e60000 {
+				compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu";
+				reg = <0x30e60000 0x10000>;
+				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+				#mbox-cells = <2>;
+				status = "disabled";
+			};
+
 			i2c5: i2c@30ad0000 {
 				compatible = "fsl,imx8mp-i2c", "fsl,imx21-i2c";
 				#address-cells = <1>;
@@ -938,5 +957,15 @@ usb_dwc3_1: usb@38200000 {
 				snps,dis-u2-freeclk-exists-quirk;
 			};
 		};
+		dsp: dsp@3b6e8000 {
+			compatible = "fsl,imx8mp-dsp";
+			reg = <0x3b6e8000 0x88000>;
+			mbox-names = "txdb0", "txdb1",
+				"rxdb0", "rxdb1";
+			mboxes = <&mu2 2 0>, <&mu2 2 1>,
+				<&mu2 3 0>, <&mu2 3 1>;
+			memory-region = <&dsp_reserved>;
+			status = "disabled";
+		};
 	};
 };
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: imx8mp: Add dsp node
  2021-07-16 12:47 [PATCH v2] arm64: dts: imx8mp: Add dsp node Daniel Baluta
@ 2021-07-16 16:07 ` Iuliana Prodan
  2021-07-23  8:02 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Iuliana Prodan @ 2021-07-16 16:07 UTC (permalink / raw)
  To: Daniel Baluta, robh+dt, shawnguo
  Cc: s.hauer, kernel, festevam, linux-imx, qiangqing.zhang, ping.bai,
	alice.guo, jun.li, peng.fan, thunder.leizhen, yibin.gong,
	devicetree, linux-arm-kernel, linux-kernel, Daniel Baluta


On 7/16/2021 3:47 PM, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
> 
> i.MX8 MPlus SoC integrates Cadence HIFI4 DSP. This core runs either a
> custom firmware or the open source SOF firmware [1]
> 
> DSP device is handled by SOF OF driver found in
> sound/soc/sof/sof-of-dev.c
> 
> Notice that the DSP node makes use of:
> 	- dsp_reserved, a reserved memory region for various Audio
> 	  resources (e.g firmware loading, audio buffers, etc).
> 	- Messaging Unit (mu2) for passing notifications betweem ARM
> 	  core and DSP.
> 
> [1] https://thesofproject.github.io/latest/platforms/index.html
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia
> ---
> Changes since v1:
> 	* mark MU2 node as disabled, because mu2 clock support is not yet upstream.
> 
>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 29 +++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9f7c7f587d38..fb0ac85c8473 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -135,6 +135,17 @@ clk_ext4: clock-ext4 {
>   		clock-output-names = "clk_ext4";
>   	};
>   
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		dsp_reserved: dsp@92400000 {
> +			reg = <0 0x92400000 0 0x2000000>;
> +			no-map;
> +		};
> +	};
> +
>   	pmu {
>   		compatible = "arm,cortex-a53-pmu";
>   		interrupts = <GIC_PPI 7
> @@ -698,6 +709,14 @@ mu: mailbox@30aa0000 {
>   				#mbox-cells = <2>;
>   			};
>   
> +			mu2: mailbox@30e60000 {
> +				compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu";
> +				reg = <0x30e60000 0x10000>;
> +				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> +				#mbox-cells = <2>;
> +				status = "disabled";
> +			};
> +
>   			i2c5: i2c@30ad0000 {
>   				compatible = "fsl,imx8mp-i2c", "fsl,imx21-i2c";
>   				#address-cells = <1>;
> @@ -938,5 +957,15 @@ usb_dwc3_1: usb@38200000 {
>   				snps,dis-u2-freeclk-exists-quirk;
>   			};
>   		};
> +		dsp: dsp@3b6e8000 {
> +			compatible = "fsl,imx8mp-dsp";
> +			reg = <0x3b6e8000 0x88000>;
> +			mbox-names = "txdb0", "txdb1",
> +				"rxdb0", "rxdb1";
> +			mboxes = <&mu2 2 0>, <&mu2 2 1>,
> +				<&mu2 3 0>, <&mu2 3 1>;
> +			memory-region = <&dsp_reserved>;
> +			status = "disabled";
> +		};
>   	};
>   };
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: imx8mp: Add dsp node
  2021-07-16 12:47 [PATCH v2] arm64: dts: imx8mp: Add dsp node Daniel Baluta
  2021-07-16 16:07 ` Iuliana Prodan
@ 2021-07-23  8:02 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-07-23  8:02 UTC (permalink / raw)
  To: Daniel Baluta
  Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, qiangqing.zhang,
	ping.bai, alice.guo, jun.li, peng.fan, thunder.leizhen,
	yibin.gong, devicetree, linux-arm-kernel, linux-kernel,
	Daniel Baluta

On Fri, Jul 16, 2021 at 03:47:19PM +0300, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
> 
> i.MX8 MPlus SoC integrates Cadence HIFI4 DSP. This core runs either a
> custom firmware or the open source SOF firmware [1]
> 
> DSP device is handled by SOF OF driver found in
> sound/soc/sof/sof-of-dev.c
> 
> Notice that the DSP node makes use of:
> 	- dsp_reserved, a reserved memory region for various Audio
> 	  resources (e.g firmware loading, audio buffers, etc).
> 	- Messaging Unit (mu2) for passing notifications betweem ARM
> 	  core and DSP.
> 
> [1] https://thesofproject.github.io/latest/platforms/index.html
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Changes since v1:
> 	* mark MU2 node as disabled, because mu2 clock support is not yet upstream.
> 
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 29 +++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9f7c7f587d38..fb0ac85c8473 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -135,6 +135,17 @@ clk_ext4: clock-ext4 {
>  		clock-output-names = "clk_ext4";
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		dsp_reserved: dsp@92400000 {
> +			reg = <0 0x92400000 0 0x2000000>;
> +			no-map;
> +		};
> +	};
> +
>  	pmu {
>  		compatible = "arm,cortex-a53-pmu";
>  		interrupts = <GIC_PPI 7
> @@ -698,6 +709,14 @@ mu: mailbox@30aa0000 {
>  				#mbox-cells = <2>;
>  			};
>  
> +			mu2: mailbox@30e60000 {
> +				compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu";
> +				reg = <0x30e60000 0x10000>;
> +				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> +				#mbox-cells = <2>;
> +				status = "disabled";
> +			};
> +
>  			i2c5: i2c@30ad0000 {
>  				compatible = "fsl,imx8mp-i2c", "fsl,imx21-i2c";
>  				#address-cells = <1>;
> @@ -938,5 +957,15 @@ usb_dwc3_1: usb@38200000 {
>  				snps,dis-u2-freeclk-exists-quirk;
>  			};
>  		};
> +		dsp: dsp@3b6e8000 {

Please have a newline between nodes.

Shawn

> +			compatible = "fsl,imx8mp-dsp";
> +			reg = <0x3b6e8000 0x88000>;
> +			mbox-names = "txdb0", "txdb1",
> +				"rxdb0", "rxdb1";
> +			mboxes = <&mu2 2 0>, <&mu2 2 1>,
> +				<&mu2 3 0>, <&mu2 3 1>;
> +			memory-region = <&dsp_reserved>;
> +			status = "disabled";
> +		};
>  	};
>  };
> -- 
> 2.27.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-23  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 12:47 [PATCH v2] arm64: dts: imx8mp: Add dsp node Daniel Baluta
2021-07-16 16:07 ` Iuliana Prodan
2021-07-23  8:02 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).