LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 1/2] perf: don't install headers with x permissions
@ 2021-07-26  9:14 Jiri Slaby
  2021-07-26  9:14 ` [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py} Jiri Slaby
  0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2021-07-26  9:14 UTC (permalink / raw)
  To: acme
  Cc: linux-perf-users, linux-kernel, Jiri Slaby, Adrian Hunter,
	Andi Kleen, Ingo Molnar, Jiri Olsa, Kan Liang, Leo Yan,
	Mark Rutland, Namhyung Kim, Peter Zijlstra

install(1), by default, installs with rwxr-xr-x permissions. Modify
perf's Makefile to pass '-m 644' when installing:
* perf_dlfilter.h header
* trace/strace/groups/*
* scripts/perl/Perf-Trace-Util/lib/Perf/Trace/*
* scripts/perl/*.pl
* perf-completion.sh
* Documentation/tips.txt
* tests/attr.py
* tests/attr/*
* tests/shell/lib/*.sh

All those are supposed to be non-executable. Either they are not scripts
at all, or they don't have shebang.

The fixes line below is only for the perf_dlfilter.h header addition...

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Fixes: 0beb218315e0 (perf build: Install perf_dlfilter.h)
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
[v2] extend to more than perf_dlfilter.h.

 tools/perf/Makefile.perf | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 77e7f18c0bd0..01bd153c4f2a 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -925,7 +925,7 @@ install-tools: all install-gtk
 		$(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)'; \
 		$(LN) '$(DESTDIR_SQ)$(bindir_SQ)/perf' '$(DESTDIR_SQ)$(bindir_SQ)/trace'; \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(includedir_SQ)/perf'; \
-		$(INSTALL) util/perf_dlfilter.h -t '$(DESTDIR_SQ)$(includedir_SQ)/perf'
+		$(INSTALL) -m 644 util/perf_dlfilter.h -t '$(DESTDIR_SQ)$(includedir_SQ)/perf'
 ifndef NO_PERF_READ_VDSO32
 	$(call QUIET_INSTALL, perf-read-vdso32) \
 		$(INSTALL) $(OUTPUT)perf-read-vdso32 '$(DESTDIR_SQ)$(bindir_SQ)';
@@ -960,13 +960,13 @@ endif
 ifndef NO_LIBAUDIT
 	$(call QUIET_INSTALL, strace/groups) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(STRACE_GROUPS_INSTDIR_SQ)'; \
-		$(INSTALL) trace/strace/groups/* -t '$(DESTDIR_SQ)$(STRACE_GROUPS_INSTDIR_SQ)'
+		$(INSTALL) trace/strace/groups/* -m 644 -t '$(DESTDIR_SQ)$(STRACE_GROUPS_INSTDIR_SQ)'
 endif
 ifndef NO_LIBPERL
 	$(call QUIET_INSTALL, perl-scripts) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/Perf-Trace-Util/lib/Perf/Trace'; \
-		$(INSTALL) scripts/perl/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/Perf-Trace-Util/lib/Perf/Trace'; \
-		$(INSTALL) scripts/perl/*.pl -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl'; \
+		$(INSTALL) scripts/perl/Perf-Trace-Util/lib/Perf/Trace/* -m 644 -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/Perf-Trace-Util/lib/Perf/Trace'; \
+		$(INSTALL) scripts/perl/*.pl -m 644 -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl'; \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/bin'; \
 		$(INSTALL) scripts/perl/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/bin'
 endif
@@ -980,22 +980,22 @@ ifndef NO_LIBPYTHON
 endif
 	$(call QUIET_INSTALL, perf_completion-script) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d'; \
-		$(INSTALL) perf-completion.sh '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
+		$(INSTALL) perf-completion.sh -m 644 '$(DESTDIR_SQ)$(sysconfdir_SQ)/bash_completion.d/perf'
 	$(call QUIET_INSTALL, perf-tip) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(tip_instdir_SQ)'; \
-		$(INSTALL) Documentation/tips.txt -t '$(DESTDIR_SQ)$(tip_instdir_SQ)'
+		$(INSTALL) Documentation/tips.txt -m 644 -t '$(DESTDIR_SQ)$(tip_instdir_SQ)'
 
 install-tests: all install-gtk
 	$(call QUIET_INSTALL, tests) \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
-		$(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
+		$(INSTALL) tests/attr.py -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
 		$(INSTALL) tests/pe-file.exe* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
-		$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
+		$(INSTALL) tests/attr/* -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'; \
 		$(INSTALL) tests/shell/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'; \
 		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
-		$(INSTALL) tests/shell/lib/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'
+		$(INSTALL) tests/shell/lib/*.sh -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'
 
 install-bin: install-tools install-tests install-traceevent-plugins
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py}
  2021-07-26  9:14 [PATCH v2 1/2] perf: don't install headers with x permissions Jiri Slaby
@ 2021-07-26  9:14 ` Jiri Slaby
  2021-08-03 11:44   ` Adrian Hunter
  0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2021-07-26  9:14 UTC (permalink / raw)
  To: acme
  Cc: linux-perf-users, linux-kernel, Jiri Slaby, Adrian Hunter,
	Andi Kleen, Ingo Molnar, Jiri Olsa, Kan Liang, Leo Yan,
	Mark Rutland, Namhyung Kim, Peter Zijlstra

The scripts cannot be executed on their own. The python ones were always
installed without x permissions, the perl ones fail anyway:
  BEGIN failed--compilation aborted at /usr/lib/perf-core/scripts/perl/rw-by-pid.pl line 18.
so there is no point to have a shebang in them. This causes rpmlint to
complain too:
  W: non-executable-script /usr/lib/perf-core/scripts/perl/rw-by-file.pl 644 /usr/bin/perl -w

Hence drop shebangs in them all and remove x permissions in the
repository. If anyone wants some of them executable, they need to fix
the install scripts first.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/perl/rw-by-file.pl            | 1 -
 tools/perf/scripts/perl/rw-by-pid.pl             | 1 -
 tools/perf/scripts/perl/rwtop.pl                 | 1 -
 tools/perf/scripts/perl/wakeup-latency.pl        | 1 -
 tools/perf/scripts/python/exported-sql-viewer.py | 1 -
 tools/perf/scripts/python/flamegraph.py          | 0
 tools/perf/scripts/python/libxed.py              | 1 -
 tools/perf/scripts/python/net_dropmonitor.py     | 0
 tools/perf/scripts/python/stackcollapse.py       | 0
 9 files changed, 6 deletions(-)
 mode change 100755 => 100644 tools/perf/scripts/python/exported-sql-viewer.py
 mode change 100755 => 100644 tools/perf/scripts/python/flamegraph.py
 mode change 100755 => 100644 tools/perf/scripts/python/net_dropmonitor.py
 mode change 100755 => 100644 tools/perf/scripts/python/stackcollapse.py

diff --git a/tools/perf/scripts/perl/rw-by-file.pl b/tools/perf/scripts/perl/rw-by-file.pl
index 92a750b8552b..e0e4e23d5597 100644
--- a/tools/perf/scripts/perl/rw-by-file.pl
+++ b/tools/perf/scripts/perl/rw-by-file.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
 # SPDX-License-Identifier: GPL-2.0-only
 # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
 
diff --git a/tools/perf/scripts/perl/rw-by-pid.pl b/tools/perf/scripts/perl/rw-by-pid.pl
index d789fe39caab..43fcd4823f21 100644
--- a/tools/perf/scripts/perl/rw-by-pid.pl
+++ b/tools/perf/scripts/perl/rw-by-pid.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
 # SPDX-License-Identifier: GPL-2.0-only
 # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
 
diff --git a/tools/perf/scripts/perl/rwtop.pl b/tools/perf/scripts/perl/rwtop.pl
index eba4df67af6b..96ce72e53f8e 100644
--- a/tools/perf/scripts/perl/rwtop.pl
+++ b/tools/perf/scripts/perl/rwtop.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
 # SPDX-License-Identifier: GPL-2.0-only
 # (c) 2010, Tom Zanussi <tzanussi@gmail.com>
 
diff --git a/tools/perf/scripts/perl/wakeup-latency.pl b/tools/perf/scripts/perl/wakeup-latency.pl
index 53444ff4ec7f..f8b59f0bd949 100644
--- a/tools/perf/scripts/perl/wakeup-latency.pl
+++ b/tools/perf/scripts/perl/wakeup-latency.pl
@@ -1,4 +1,3 @@
-#!/usr/bin/perl -w
 # SPDX-License-Identifier: GPL-2.0-only
 # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
 
diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py
old mode 100755
new mode 100644
index 13f2d8a81610..358438a648a9
--- a/tools/perf/scripts/python/exported-sql-viewer.py
+++ b/tools/perf/scripts/python/exported-sql-viewer.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # SPDX-License-Identifier: GPL-2.0
 # exported-sql-viewer.py: view data from sql database
 # Copyright (c) 2014-2018, Intel Corporation.
diff --git a/tools/perf/scripts/python/flamegraph.py b/tools/perf/scripts/python/flamegraph.py
old mode 100755
new mode 100644
diff --git a/tools/perf/scripts/python/libxed.py b/tools/perf/scripts/python/libxed.py
index 2c70a5a7eb9c..3ea5bb8195c4 100644
--- a/tools/perf/scripts/python/libxed.py
+++ b/tools/perf/scripts/python/libxed.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # SPDX-License-Identifier: GPL-2.0
 # libxed.py: Python wrapper for libxed.so
 # Copyright (c) 2014-2021, Intel Corporation.
diff --git a/tools/perf/scripts/python/net_dropmonitor.py b/tools/perf/scripts/python/net_dropmonitor.py
old mode 100755
new mode 100644
diff --git a/tools/perf/scripts/python/stackcollapse.py b/tools/perf/scripts/python/stackcollapse.py
old mode 100755
new mode 100644
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py}
  2021-07-26  9:14 ` [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py} Jiri Slaby
@ 2021-08-03 11:44   ` Adrian Hunter
  2021-08-04  5:49     ` Jiri Slaby
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Hunter @ 2021-08-03 11:44 UTC (permalink / raw)
  To: Jiri Slaby, acme
  Cc: linux-perf-users, linux-kernel, Andi Kleen, Ingo Molnar,
	Jiri Olsa, Kan Liang, Leo Yan, Mark Rutland, Namhyung Kim,
	Peter Zijlstra

On 26/07/21 12:14 pm, Jiri Slaby wrote:
> The scripts cannot be executed on their own. The python ones were always
> installed without x permissions, the perl ones fail anyway:
>   BEGIN failed--compilation aborted at /usr/lib/perf-core/scripts/perl/rw-by-pid.pl line 18.
> so there is no point to have a shebang in them. This causes rpmlint to
> complain too:
>   W: non-executable-script /usr/lib/perf-core/scripts/perl/rw-by-file.pl 644 /usr/bin/perl -w
> 
> Hence drop shebangs in them all and remove x permissions in the
> repository. If anyone wants some of them executable, they need to fix
> the install scripts first.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/scripts/perl/rw-by-file.pl            | 1 -
>  tools/perf/scripts/perl/rw-by-pid.pl             | 1 -
>  tools/perf/scripts/perl/rwtop.pl                 | 1 -
>  tools/perf/scripts/perl/wakeup-latency.pl        | 1 -
>  tools/perf/scripts/python/exported-sql-viewer.py | 1 -

exported-sql-viewer.py is a standalone executable


>  tools/perf/scripts/python/flamegraph.py          | 0
>  tools/perf/scripts/python/libxed.py              | 1 -
>  tools/perf/scripts/python/net_dropmonitor.py     | 0
>  tools/perf/scripts/python/stackcollapse.py       | 0
>  9 files changed, 6 deletions(-)
>  mode change 100755 => 100644 tools/perf/scripts/python/exported-sql-viewer.py
>  mode change 100755 => 100644 tools/perf/scripts/python/flamegraph.py
>  mode change 100755 => 100644 tools/perf/scripts/python/net_dropmonitor.py
>  mode change 100755 => 100644 tools/perf/scripts/python/stackcollapse.py
> 
> diff --git a/tools/perf/scripts/perl/rw-by-file.pl b/tools/perf/scripts/perl/rw-by-file.pl
> index 92a750b8552b..e0e4e23d5597 100644
> --- a/tools/perf/scripts/perl/rw-by-file.pl
> +++ b/tools/perf/scripts/perl/rw-by-file.pl
> @@ -1,4 +1,3 @@
> -#!/usr/bin/perl -w
>  # SPDX-License-Identifier: GPL-2.0-only
>  # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
>  
> diff --git a/tools/perf/scripts/perl/rw-by-pid.pl b/tools/perf/scripts/perl/rw-by-pid.pl
> index d789fe39caab..43fcd4823f21 100644
> --- a/tools/perf/scripts/perl/rw-by-pid.pl
> +++ b/tools/perf/scripts/perl/rw-by-pid.pl
> @@ -1,4 +1,3 @@
> -#!/usr/bin/perl -w
>  # SPDX-License-Identifier: GPL-2.0-only
>  # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
>  
> diff --git a/tools/perf/scripts/perl/rwtop.pl b/tools/perf/scripts/perl/rwtop.pl
> index eba4df67af6b..96ce72e53f8e 100644
> --- a/tools/perf/scripts/perl/rwtop.pl
> +++ b/tools/perf/scripts/perl/rwtop.pl
> @@ -1,4 +1,3 @@
> -#!/usr/bin/perl -w
>  # SPDX-License-Identifier: GPL-2.0-only
>  # (c) 2010, Tom Zanussi <tzanussi@gmail.com>
>  
> diff --git a/tools/perf/scripts/perl/wakeup-latency.pl b/tools/perf/scripts/perl/wakeup-latency.pl
> index 53444ff4ec7f..f8b59f0bd949 100644
> --- a/tools/perf/scripts/perl/wakeup-latency.pl
> +++ b/tools/perf/scripts/perl/wakeup-latency.pl
> @@ -1,4 +1,3 @@
> -#!/usr/bin/perl -w
>  # SPDX-License-Identifier: GPL-2.0-only
>  # (c) 2009, Tom Zanussi <tzanussi@gmail.com>
>  
> diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py
> old mode 100755
> new mode 100644
> index 13f2d8a81610..358438a648a9
> --- a/tools/perf/scripts/python/exported-sql-viewer.py
> +++ b/tools/perf/scripts/python/exported-sql-viewer.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # SPDX-License-Identifier: GPL-2.0
>  # exported-sql-viewer.py: view data from sql database
>  # Copyright (c) 2014-2018, Intel Corporation.
> diff --git a/tools/perf/scripts/python/flamegraph.py b/tools/perf/scripts/python/flamegraph.py
> old mode 100755
> new mode 100644
> diff --git a/tools/perf/scripts/python/libxed.py b/tools/perf/scripts/python/libxed.py
> index 2c70a5a7eb9c..3ea5bb8195c4 100644
> --- a/tools/perf/scripts/python/libxed.py
> +++ b/tools/perf/scripts/python/libxed.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # SPDX-License-Identifier: GPL-2.0
>  # libxed.py: Python wrapper for libxed.so
>  # Copyright (c) 2014-2021, Intel Corporation.
> diff --git a/tools/perf/scripts/python/net_dropmonitor.py b/tools/perf/scripts/python/net_dropmonitor.py
> old mode 100755
> new mode 100644
> diff --git a/tools/perf/scripts/python/stackcollapse.py b/tools/perf/scripts/python/stackcollapse.py
> old mode 100755
> new mode 100644
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py}
  2021-08-03 11:44   ` Adrian Hunter
@ 2021-08-04  5:49     ` Jiri Slaby
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2021-08-04  5:49 UTC (permalink / raw)
  To: Adrian Hunter, acme
  Cc: linux-perf-users, linux-kernel, Andi Kleen, Ingo Molnar,
	Jiri Olsa, Kan Liang, Leo Yan, Mark Rutland, Namhyung Kim,
	Peter Zijlstra

On 03. 08. 21, 13:44, Adrian Hunter wrote:
> On 26/07/21 12:14 pm, Jiri Slaby wrote:
>> The scripts cannot be executed on their own. The python ones were always
>> installed without x permissions, the perl ones fail anyway:
>>    BEGIN failed--compilation aborted at /usr/lib/perf-core/scripts/perl/rw-by-pid.pl line 18.
>> so there is no point to have a shebang in them. This causes rpmlint to
>> complain too:
>>    W: non-executable-script /usr/lib/perf-core/scripts/perl/rw-by-file.pl 644 /usr/bin/perl -w
>>
>> Hence drop shebangs in them all and remove x permissions in the
>> repository. If anyone wants some of them executable, they need to fix
>> the install scripts first.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Andi Kleen <ak@linux.intel.com>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Cc: Kan Liang <kan.liang@linux.intel.com>
>> Cc: Leo Yan <leo.yan@linaro.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>>   tools/perf/scripts/perl/rw-by-file.pl            | 1 -
>>   tools/perf/scripts/perl/rw-by-pid.pl             | 1 -
>>   tools/perf/scripts/perl/rwtop.pl                 | 1 -
>>   tools/perf/scripts/perl/wakeup-latency.pl        | 1 -
>>   tools/perf/scripts/python/exported-sql-viewer.py | 1 -
> 
> exported-sql-viewer.py is a standalone executable

That's great, but in fact noone can run it when make-installed as I 
stated above:

 >> If anyone wants some of them executable, they need to fix
 >> the install scripts first.

See:
$(INSTALL) scripts/python/*.py -m 644 -t 
'$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python';

thanks,
-- 
js
suse labs

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-04  5:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  9:14 [PATCH v2 1/2] perf: don't install headers with x permissions Jiri Slaby
2021-07-26  9:14 ` [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py} Jiri Slaby
2021-08-03 11:44   ` Adrian Hunter
2021-08-04  5:49     ` Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).