LKML Archive on
help / color / mirror / Atom feed
* [PATCH] serial: 8250_pci: make setup_port() parameters explicitly unsigned
@ 2021-07-26 13:07 Greg Kroah-Hartman
  0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2021-07-26 13:07 UTC (permalink / raw)
  To: linux-serial; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Jordy Zomer

The bar and offset parameters to setup_port() are used in pointer math,
and while it would be very difficult to get them to wrap as a negative
number, just be "safe" and make them unsigned so that static checkers do
not trip over them unintentionally.

Cc: Jiri Slaby <>
Reported-by: Jordy Zomer <>
Signed-off-by: Greg Kroah-Hartman <>
 drivers/tty/serial/8250/8250_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 75827b608fdb..fe64f77a9789 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -87,7 +87,7 @@ static void moan_device(const char *str, struct pci_dev *dev)
 static int
 setup_port(struct serial_private *priv, struct uart_8250_port *port,
-	   int bar, int offset, int regshift)
+	   u8 bar, unsigned int offset, int regshift)
 	struct pci_dev *dev = priv->dev;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-26 13:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 13:07 [PATCH] serial: 8250_pci: make setup_port() parameters explicitly unsigned Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).