LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Anirudh Rayabharam <mail@anirudhrb.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
	skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	syzbot+de271708674e2093097b@syzkaller.appspotmail.com
Subject: Re: [PATCH v7 2/2] firmware_loader: fix use-after-free in firmware_fallback_sysfs
Date: Mon, 26 Jul 2021 11:27:21 -0700	[thread overview]
Message-ID: <20210726182721.3no7ql73ggttdiyx@garbanzo> (raw)
In-Reply-To: <20210724121134.6364-3-mail@anirudhrb.com>

On Sat, Jul 24, 2021 at 05:41:34PM +0530, Anirudh Rayabharam wrote:
> This use-after-free happens when a fw_priv object has been freed but
> hasn't been removed from the pending list (pending_fw_head). The next
> time fw_load_sysfs_fallback tries to insert into the list, it ends up
> accessing the pending_list member of the previoiusly freed fw_priv.
> 
> The root cause here is that all code paths that abort the fw load
> don't delete it from the pending list. For example:
> 
> 	_request_firmware()
> 	  -> fw_abort_batch_reqs()
> 	      -> fw_state_aborted()
> 
> To fix this, delete the fw_priv from the list in __fw_set_state() if
> the new state is DONE or ABORTED. This way, all aborts will remove
> the fw_priv from the list. Accordingly, remove calls to list_del_init
> that were being made before calling fw_state_(aborted|done).
> 
> Also, in fw_load_sysfs_fallback, don't add the fw_priv to the pending
> list if it is already aborted. Instead, just jump out and return early.
> 
> Fixes: bcfbd3523f3c ("firmware: fix a double abort case with fw_load_sysfs_fallback")
> Reported-by: syzbot+de271708674e2093097b@syzkaller.appspotmail.com
> Tested-by: syzbot+de271708674e2093097b@syzkaller.appspotmail.com

Curious, how do you get syzbot to test this, I mean your custom tree?

> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>

With the changes Shua requested being made:

Acked-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis

  parent reply	other threads:[~2021-07-26 18:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 12:11 [PATCH v7 0/2] firmware_loader: fix uaf " Anirudh Rayabharam
2021-07-24 12:11 ` [PATCH v7 1/2] firmware_loader: use -ETIMEDOUT instead of -EAGAIN in fw_load_sysfs_fallback Anirudh Rayabharam
2021-07-26 16:56   ` Shuah Khan
2021-07-26 18:07   ` Luis Chamberlain
2021-07-24 12:11 ` [PATCH v7 2/2] firmware_loader: fix use-after-free in firmware_fallback_sysfs Anirudh Rayabharam
2021-07-26 17:22   ` Shuah Khan
2021-07-26 18:27   ` Luis Chamberlain [this message]
2021-07-27 12:57     ` Anirudh Rayabharam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726182721.3no7ql73ggttdiyx@garbanzo \
    --to=mcgrof@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@anirudhrb.com \
    --cc=rafael@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=syzbot+de271708674e2093097b@syzkaller.appspotmail.com \
    --subject='Re: [PATCH v7 2/2] firmware_loader: fix use-after-free in firmware_fallback_sysfs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).