LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>
@ 2021-07-27  9:28 Cai Huoqing
  2021-07-27  9:28 ` [PATCH V2] soc/tegra: bpmp: " Cai Huoqing
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Cai Huoqing @ 2021-07-27  9:28 UTC (permalink / raw)
  To: laurent.pinchart, mchehab, thierry.reding, jonathanh
  Cc: linux-media, linux-kernel, linux-tegra, Cai Huoqing

Remove including <linux/version.h> that don't need it.

V1->V2: Split the patch in two.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 9a791d8ef200..b1b055784f8d 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -16,7 +16,6 @@
 #include <linux/videodev2.h>
 #include <linux/vmalloc.h>
 #include <linux/wait.h>
-#include <linux/version.h>
 #include <asm/unaligned.h>
 
 #include <media/v4l2-common.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V2] soc/tegra: bpmp: Remove unused including <linux/version.h>
  2021-07-27  9:28 [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h> Cai Huoqing
@ 2021-07-27  9:28 ` Cai Huoqing
  2021-07-27 20:49   ` Randy Dunlap
  2021-07-27 20:50 ` [PATCH V2] media: uvcvideo: " Randy Dunlap
  2021-07-28  5:45 ` Laurent Pinchart
  2 siblings, 1 reply; 5+ messages in thread
From: Cai Huoqing @ 2021-07-27  9:28 UTC (permalink / raw)
  To: laurent.pinchart, mchehab, thierry.reding, jonathanh
  Cc: linux-media, linux-kernel, linux-tegra, Cai Huoqing

Remove including <linux/version.h> that don't need it.

V1->V2: Split the patch in two

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/soc/tegra/powergate-bpmp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
index 06c792bafca5..8eaf50d0b6af 100644
--- a/drivers/soc/tegra/powergate-bpmp.c
+++ b/drivers/soc/tegra/powergate-bpmp.c
@@ -7,7 +7,6 @@
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
 #include <linux/slab.h>
-#include <linux/version.h>
 
 #include <soc/tegra/bpmp.h>
 #include <soc/tegra/bpmp-abi.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] soc/tegra: bpmp: Remove unused including <linux/version.h>
  2021-07-27  9:28 ` [PATCH V2] soc/tegra: bpmp: " Cai Huoqing
@ 2021-07-27 20:49   ` Randy Dunlap
  0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-07-27 20:49 UTC (permalink / raw)
  To: Cai Huoqing, laurent.pinchart, mchehab, thierry.reding, jonathanh
  Cc: linux-media, linux-kernel, linux-tegra

On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> V1->V2: Split the patch in two
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

as reported by 'make versioncheck':

../drivers/soc/tegra/powergate-bpmp.c: 10 linux/version.h not needed.

thanks.

> ---
>  drivers/soc/tegra/powergate-bpmp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
> index 06c792bafca5..8eaf50d0b6af 100644
> --- a/drivers/soc/tegra/powergate-bpmp.c
> +++ b/drivers/soc/tegra/powergate-bpmp.c
> @@ -7,7 +7,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/pm_domain.h>
>  #include <linux/slab.h>
> -#include <linux/version.h>
>  
>  #include <soc/tegra/bpmp.h>
>  #include <soc/tegra/bpmp-abi.h>
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>
  2021-07-27  9:28 [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h> Cai Huoqing
  2021-07-27  9:28 ` [PATCH V2] soc/tegra: bpmp: " Cai Huoqing
@ 2021-07-27 20:50 ` Randy Dunlap
  2021-07-28  5:45 ` Laurent Pinchart
  2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-07-27 20:50 UTC (permalink / raw)
  To: Cai Huoqing, laurent.pinchart, mchehab, thierry.reding, jonathanh
  Cc: linux-media, linux-kernel, linux-tegra

On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> V1->V2: Split the patch in two.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

as reported by 'make versioncheck':

../drivers/media/usb/uvc/uvc_driver.c: 19 linux/version.h not needed.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

thanks.

> ---
>  drivers/media/usb/uvc/uvc_driver.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
>  #include <linux/videodev2.h>
>  #include <linux/vmalloc.h>
>  #include <linux/wait.h>
> -#include <linux/version.h>
>  #include <asm/unaligned.h>
>  
>  #include <media/v4l2-common.h>
> 


-- 
~Randy


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h>
  2021-07-27  9:28 [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h> Cai Huoqing
  2021-07-27  9:28 ` [PATCH V2] soc/tegra: bpmp: " Cai Huoqing
  2021-07-27 20:50 ` [PATCH V2] media: uvcvideo: " Randy Dunlap
@ 2021-07-28  5:45 ` Laurent Pinchart
  2 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2021-07-28  5:45 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: mchehab, thierry.reding, jonathanh, linux-media, linux-kernel,
	linux-tegra

Hi Cai,

Thank you for the patch.

On Tue, Jul 27, 2021 at 05:28:53PM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> V1->V2: Split the patch in two.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Taken in my tree for v5.15. Thank you.

> ---
>  drivers/media/usb/uvc/uvc_driver.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..b1b055784f8d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -16,7 +16,6 @@
>  #include <linux/videodev2.h>
>  #include <linux/vmalloc.h>
>  #include <linux/wait.h>
> -#include <linux/version.h>
>  #include <asm/unaligned.h>
>  
>  #include <media/v4l2-common.h>

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-28  5:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  9:28 [PATCH V2] media: uvcvideo: Remove unused including <linux/version.h> Cai Huoqing
2021-07-27  9:28 ` [PATCH V2] soc/tegra: bpmp: " Cai Huoqing
2021-07-27 20:49   ` Randy Dunlap
2021-07-27 20:50 ` [PATCH V2] media: uvcvideo: " Randy Dunlap
2021-07-28  5:45 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).