LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Evan Green <>
Cc: David Hildenbrand <>,
	Michal Hocko <>, Pavel Machek <>,, Alex Shi <>,
	Alistair Popple <>,
	Johannes Weiner <>,
	Joonsoo Kim <>,
	"Matthew Wilcox (Oracle)" <>,
	Miaohe Lin <>,
	Minchan Kim <>,
	Suren Baghdasaryan <>,
	Vlastimil Babka <>,
	LKML <>,
Subject: Re: [PATCH v4] mm: Enable suspend-only swap spaces
Date: Tue, 27 Jul 2021 14:18:32 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 27 Jul 2021 09:31:33 -0700 Evan Green <> wrote:

> > Pavel just mentioned uswsusp, and I wonder if it would be a possible
> > alternative to this patch.
> I think you're right that it would be possible to isolate the
> hibernate image with uswsusp if you avoid using the SNAPSHOT_*SWAP*
> ioctls. But I'd expect performance to suffer noticeably, since now
> every page is making a round trip out to usermode and back. I'd still
> very much use the HIBERNATE_ONLY flag if it were accepted, I think
> there's value to it.

The uswsusp option makes your patch a performance optimization rather
than a feature-add.  And we do like to see quantitative testing results
when considering a performance optimization.  Especially when the
performance optimization is a bit icky, putting special-case testing
all over the place, maintenance cost, additional testing effort, etc.

I do think that diligence demands that we quantify the difference.  Is
this a thing you can help with?

  reply	other threads:[~2021-07-27 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  0:12 [PATCH v4] mm: Enable suspend-only swap spaces Evan Green
2021-07-27  9:48 ` David Hildenbrand
2021-07-27 12:21   ` David Hildenbrand
2021-07-27 16:31     ` Evan Green
2021-07-27 21:18       ` Andrew Morton [this message]
2021-08-03 18:00         ` Evan Green
2021-08-17 18:32           ` Pavel Machek
2021-07-30 13:15 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).