LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] nfc: s3fwrn5: fix undefined parameter values in dev_err()
@ 2021-07-28  1:49 Tang Bin
  0 siblings, 0 replies; only message in thread
From: Tang Bin @ 2021-07-28  1:49 UTC (permalink / raw)
  To: k.opasiak, davem, nathan; +Cc: netdev, linux-kernel, Tang Bin, Zhang Shengju

In the function s3fwrn5_fw_download(), the 'ret' is not assigned,
so the correct value should be given in dev_err function.

Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
---
Changes from v1
 - Modify the code in another form
---
 drivers/nfc/s3fwrn5/firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index 1421ffd46d9a..1af7a1e632cf 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc/s3fwrn5/firmware.c
@@ -422,7 +422,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info)
 	tfm = crypto_alloc_shash("sha1", 0, 0);
 	if (IS_ERR(tfm)) {
 		dev_err(&fw_info->ndev->nfc_dev->dev,
-			"Cannot allocate shash (code=%d)\n", ret);
+			"Cannot allocate shash (code=%pe)\n", tfm);
 		return PTR_ERR(tfm);
 	}
 
-- 
2.18.2




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-28  1:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28  1:49 [PATCH v2] nfc: s3fwrn5: fix undefined parameter values in dev_err() Tang Bin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).