LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ojaswin Mujoo <ojaswin98@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: nsaenz@kernel.org, stefan.wahren@i2se.com,
	dan.carpenter@oracle.com, phil@raspberrypi.com,
	linux-arm-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default
Date: Thu, 29 Jul 2021 01:36:07 +0530	[thread overview]
Message-ID: <20210728200607.GB17046@ojas> (raw)
In-Reply-To: <YQGl47Wpu7+SHIW+@kroah.com>

On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote:
> On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote:
> > Before this config was defined, the cdev used to be created
> > unconditionally. When an earlier commit introduced this config, the
> > default behavior was set to disabled, which might surprise some
> > unsuspecting users.  Hence, make this config default to 'Y' to be more
> > backward consistent.
> > 
> > Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> > ---
> >  drivers/staging/vc04_services/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> > index 63caa6818d37..2b70c37cdd09 100644
> > --- a/drivers/staging/vc04_services/Kconfig
> > +++ b/drivers/staging/vc04_services/Kconfig
> > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ
> >  
> >  config VCHIQ_CDEV
> >  	bool "VCHIQ Character Driver"
> > +	default y
> 
> 
> default y is only if the machine will not work without this option.
> Is that the case here?  If not, then please do not have this as the
> default.
Got it Greg. 

From my testing, the Raspberry Pi does seem to boot correctly without
this although some userspace libraries might not work. 

Since the machine itself works, I guess I'll drop this patch.

Thank you!
Ojaswin
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2021-07-28 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 18:37 [PATCH 0/2] staging: vchiq: Minor fixups to CONFIG_VCHIQ_CDEV Ojaswin Mujoo
2021-07-28 18:37 ` [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Ojaswin Mujoo
2021-07-28 18:45   ` Greg KH
2021-07-28 20:06     ` Ojaswin Mujoo [this message]
2021-07-28 20:21       ` Stefan Wahren
2021-07-29 14:20         ` Ojaswin Mujoo
2021-07-28 18:37 ` [PATCH 2/2] staging: vchiq: Add details to $CONFIG_VCHIQ_CDEV help text Ojaswin Mujoo
2021-07-28 18:46   ` Greg KH
2021-07-28 20:00     ` Ojaswin Mujoo
2021-07-28 20:39       ` Stefan Wahren
2021-07-29 13:47         ` Ojaswin Mujoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728200607.GB17046@ojas \
    --to=ojaswin98@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    --subject='Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).