LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] auxdisplay: code indent should use tabs where possible
@ 2021-07-29  6:39 Huiquan Deng
  0 siblings, 0 replies; 3+ messages in thread
From: Huiquan Deng @ 2021-07-29  6:39 UTC (permalink / raw)
  To: ojeda; +Cc: linux-kernel, Huiquan Deng

Resolves the checkpatch error.

Signed-off-by: Huiquan Deng <denghuiquan@cdjrlc.com>
---
 drivers/auxdisplay/cfag12864bfb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c
index d66821adf453..1e040e83d1c1 100644
--- a/drivers/auxdisplay/cfag12864bfb.c
+++ b/drivers/auxdisplay/cfag12864bfb.c
@@ -41,8 +41,8 @@ static const struct fb_var_screeninfo cfag12864bfb_var = {
 	.yres_virtual = CFAG12864B_HEIGHT,
 	.bits_per_pixel = 1,
 	.red = { 0, 1, 0 },
-      	.green = { 0, 1, 0 },
-      	.blue = { 0, 1, 0 },
+	.green = { 0, 1, 0 },
+	.blue = { 0, 1, 0 },
 	.left_margin = 0,
 	.right_margin = 0,
 	.upper_margin = 0,
@@ -69,8 +69,8 @@ static const struct fb_ops cfag12864bfb_ops = {
 
 static int cfag12864bfb_probe(struct platform_device *device)
 {
+	struct fb_info *info = framebuffer_alloc(0, &device->dev);
 	int ret = -EINVAL;
- 	struct fb_info *info = framebuffer_alloc(0, &device->dev);
 
 	if (!info)
 		goto none;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] auxdisplay: code indent should use tabs where possible
  2021-07-29  7:26 Huiquan Deng
@ 2021-10-21 22:17 ` Miguel Ojeda
  0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2021-10-21 22:17 UTC (permalink / raw)
  To: Huiquan Deng; +Cc: linux-kernel, Miguel Ojeda

On Thu, Jul 29, 2021 at 9:27 AM Huiquan Deng <denghuiquan@cdjrlc.com> wrote:
>
>  static int cfag12864bfb_probe(struct platform_device *device)
>  {
> +       struct fb_info *info = framebuffer_alloc(0, &device->dev);
>         int ret = -EINVAL;
> -       struct fb_info *info = framebuffer_alloc(0, &device->dev);

Applied, thanks!

Having said that, I fixed the patch to avoid moving the line above around `ret`.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] auxdisplay: code indent should use tabs where possible
@ 2021-07-29  7:26 Huiquan Deng
  2021-10-21 22:17 ` Miguel Ojeda
  0 siblings, 1 reply; 3+ messages in thread
From: Huiquan Deng @ 2021-07-29  7:26 UTC (permalink / raw)
  To: linux-kernel; +Cc: ojeda, Huiquan Deng

Resolves the checkpatch error.

Signed-off-by: Huiquan Deng <denghuiquan@cdjrlc.com>
---
 drivers/auxdisplay/cfag12864bfb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c
index d66821adf453..1e040e83d1c1 100644
--- a/drivers/auxdisplay/cfag12864bfb.c
+++ b/drivers/auxdisplay/cfag12864bfb.c
@@ -41,8 +41,8 @@ static const struct fb_var_screeninfo cfag12864bfb_var = {
 	.yres_virtual = CFAG12864B_HEIGHT,
 	.bits_per_pixel = 1,
 	.red = { 0, 1, 0 },
-      	.green = { 0, 1, 0 },
-      	.blue = { 0, 1, 0 },
+	.green = { 0, 1, 0 },
+	.blue = { 0, 1, 0 },
 	.left_margin = 0,
 	.right_margin = 0,
 	.upper_margin = 0,
@@ -69,8 +69,8 @@ static const struct fb_ops cfag12864bfb_ops = {
 
 static int cfag12864bfb_probe(struct platform_device *device)
 {
+	struct fb_info *info = framebuffer_alloc(0, &device->dev);
 	int ret = -EINVAL;
- 	struct fb_info *info = framebuffer_alloc(0, &device->dev);
 
 	if (!info)
 		goto none;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-21 22:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  6:39 [PATCH] auxdisplay: code indent should use tabs where possible Huiquan Deng
2021-07-29  7:26 Huiquan Deng
2021-10-21 22:17 ` Miguel Ojeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).