LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Liang Wang <wangliang101@huawei.com>
To: <palmerdabbelt@google.com>, <mcgrof@kernel.org>,
	<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<linux@armlinux.org.uk>, <linux-arm-kernel@lists.infradead.org>
Cc: <stable@vger.kernel.org>, <wangliang101@huawei.com>,
	<wangle6@huawei.com>, <kepler.chenxin@huawei.com>,
	<nixiaoming@huawei.com>, <wangkefeng.wang@huawei.com>
Subject: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
Date: Fri, 30 Jul 2021 15:43:15 +0800	[thread overview]
Message-ID: <20210730074315.63232-1-wangliang101@huawei.com> (raw)

The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled),
use PFN_PHYS() in devmem_is_allowed(), or the physical address may
overflow and be truncated.

This bug was initially introduced from v2.6.37, and the function was moved
to lib when v5.11.

Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc: stable@vger.kernel.org # v2.6.37
Signed-off-by: Liang Wang <wangliang101@huawei.com>
---
v2: update subject and changelog
 lib/devmem_is_allowed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/devmem_is_allowed.c b/lib/devmem_is_allowed.c
index c0d67c541849..60be9e24bd57 100644
--- a/lib/devmem_is_allowed.c
+++ b/lib/devmem_is_allowed.c
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)
 {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;
-- 
2.32.0


             reply	other threads:[~2021-07-30  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30  7:43 Liang Wang [this message]
2021-07-30 19:36 ` Luis Chamberlain
2021-07-31  2:04   ` 答复: " wangliang (C)
  -- strict thread matches above, loose matches on Subject: below --
2021-07-31  2:16 撤回: " wangliang (C)
     [not found] <20210730064915.56249-1-wangliang101@huawei.com>
2021-07-30  7:04 ` Kefeng Wang
2021-08-04  0:20   ` Palmer Dabbelt
2021-08-04  5:03     ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730074315.63232-1-wangliang101@huawei.com \
    --to=wangliang101@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kepler.chenxin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcgrof@kernel.org \
    --cc=nixiaoming@huawei.com \
    --cc=palmerdabbelt@google.com \
    --cc=stable@vger.kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=wangle6@huawei.com \
    --subject='Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).