LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <linux-mm@kvack.org>,
<linux-fsdevel@vger.kernel.org>, <dm-devel@redhat.com>
Cc: <djwong@kernel.com>, <dan.j.williams@intel.com>,
<david@fromorbit.com>, <hch@lst.de>, <agk@redhat.com>,
<snitzer@redhat.com>
Subject: [PATCH v6 9/9] fsdax: add exception for reflinked files
Date: Fri, 30 Jul 2021 16:52:45 +0800 [thread overview]
Message-ID: <20210730085245.3069812-10-ruansy.fnst@fujitsu.com> (raw)
In-Reply-To: <20210730085245.3069812-1-ruansy.fnst@fujitsu.com>
For reflinked files, one dax page may be associated more than once with
different fime mapping and index. It will report warning. Now, since
we have introduced dax-RMAP for this case and also have to keep its
functionality for other filesystems who are not support rmap, I add this
exception here.
Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
---
fs/dax.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index dce6307a12eb..f5910d178695 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -352,9 +352,10 @@ static void dax_associate_entry(void *entry, struct address_space *mapping,
for_each_mapped_pfn(entry, pfn) {
struct page *page = pfn_to_page(pfn);
- WARN_ON_ONCE(page->mapping);
- page->mapping = mapping;
- page->index = index + i++;
+ if (!page->mapping) {
+ page->mapping = mapping;
+ page->index = index + i++;
+ }
}
}
@@ -370,9 +371,10 @@ static void dax_disassociate_entry(void *entry, struct address_space *mapping,
struct page *page = pfn_to_page(pfn);
WARN_ON_ONCE(trunc && page_ref_count(page) > 1);
- WARN_ON_ONCE(page->mapping && page->mapping != mapping);
- page->mapping = NULL;
- page->index = 0;
+ if (page->mapping == mapping) {
+ page->mapping = NULL;
+ page->index = 0;
+ }
}
}
--
2.32.0
prev parent reply other threads:[~2021-07-30 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 8:52 [PATCH v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 4/9] pmem,mm: Implement ->memory_failure in pmem driver Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 6/9] xfs: Implement ->corrupted_range() for XFS Shiyang Ruan
2021-07-30 9:15 ` David Hildenbrand
2021-07-30 9:25 ` ruansy.fnst
2021-07-30 8:52 ` [PATCH v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan
2021-07-30 8:52 ` [PATCH v6 8/9] md: Implement dax_holder_operations Shiyang Ruan
2021-07-30 8:52 ` Shiyang Ruan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730085245.3069812-10-ruansy.fnst@fujitsu.com \
--to=ruansy.fnst@fujitsu.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--subject='Re: [PATCH v6 9/9] fsdax: add exception for reflinked files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).