From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703F3C4338F for ; Sat, 31 Jul 2021 00:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC1260FE7 for ; Sat, 31 Jul 2021 00:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234680AbhGaAYH (ORCPT ); Fri, 30 Jul 2021 20:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234459AbhGaAYE (ORCPT ); Fri, 30 Jul 2021 20:24:04 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F91C06175F for ; Fri, 30 Jul 2021 17:23:59 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id p5so13343228wro.7 for ; Fri, 30 Jul 2021 17:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1x7J72bz0//FnktNoXDcuPvaVh8FGIGtRtGljqXJxPI=; b=W7sDYvj/CAScpi5Et0a3yj48P9hnshxp9Kt7chNOVK+qL9CvCHxuCbjkUhoFI4bQZy oj3zIK6yS5OuzbHyZlXSI/mgN3ho+7MBuQICxUkWxx/OvQxTkAoyrcI9QGCHv1aOqvmo FCZ7Mz7VIX3j0cKwUGAddRsgeiVYEEn+UDaHQLUk72wdpatm3gGRFfnHeC3Zldmg9pGO e/DJXi2j4P6+++gw8NRfE9PhBu1a6o2Z3XraxZxSsT40vgdwlQ64SjSS+a3IVrLz+ZJu Ht+Ops+m+/3tKtJvCu61pPwq52+i69Pa4Uya5sozN1xIwoyrPgIEWp+MoD1FEvVMftyQ tDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1x7J72bz0//FnktNoXDcuPvaVh8FGIGtRtGljqXJxPI=; b=gjIWQ5p3r15CHcQ+iO89a7ICgrGvi+BLDHRey3yyhGVMcHhCZ4N1OfF/ntcJchHnfq A8NDhdht90hLSsZ/vmxKHJI/93FCKn3BTvDVOyUfyHnTv7hF07w0pEaqcvyLW4nC16/d EFhDclt8zKaK4vkCimU0WaOb5DKKPQjnGoQ/P0bJgoAhLXFsKhgRrxEd3jhGOARJYEvp 4Nva86zoCkpB00hStKeqK5UCLB0XIKoNnRxn5qqi1N6syrQCPglWzIH8M0VTBpWIexVJ v1qPmb7uOZcfKnQx154ZLkhwyVeXDCBVyRmNiFuCkwNfWN+RdMEx+fJWctv3qb43keJ/ +lrQ== X-Gm-Message-State: AOAM530M5LP10hWKm/7l1zTdZvHiL/E98+GuPZNeW6H/UmvmDWP66H2t FaWpW0/H78+edyV36Cu1wk/qsg== X-Google-Smtp-Source: ABdhPJxBImAH3B/wBIqq3cq9BIPEU7cBXleMaMh34sPoLdJW93Uzon+E036iJ5A47doDLRVA140xKA== X-Received: by 2002:adf:f112:: with SMTP id r18mr5632537wro.160.1627691037685; Fri, 30 Jul 2021 17:23:57 -0700 (PDT) Received: from localhost.localdomain (3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.6.1.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:df16::3]) by smtp.gmail.com with ESMTPSA id x9sm3236011wmj.41.2021.07.30.17.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 17:23:57 -0700 (PDT) From: Phillip Potter To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/14] staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller Date: Sat, 31 Jul 2021 01:23:42 +0100 Message-Id: <20210731002353.68479-4-phil@philpotter.co.uk> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210731002353.68479-1-phil@philpotter.co.uk> References: <20210731002353.68479-1-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove ODM_RT_ASSERT macro definition from include/odm_debug.h and its one caller in hal/odm.c, as this debug code is against best practice. Signed-off-by: Phillip Potter --- drivers/staging/r8188eu/hal/odm.c | 1 - drivers/staging/r8188eu/include/odm_debug.h | 9 --------- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c index c6c184d95fee..fa3973393eda 100644 --- a/drivers/staging/r8188eu/hal/odm.c +++ b/drivers/staging/r8188eu/hal/odm.c @@ -1373,7 +1373,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate LowRSSIThreshForRA += GoUpGap; break; default: - ODM_RT_ASSERT(pDM_Odm, false, ("wrong rssi level setting %d !", *pRATRState)); break; } diff --git a/drivers/staging/r8188eu/include/odm_debug.h b/drivers/staging/r8188eu/include/odm_debug.h index 73fdea598707..c11d8925952c 100644 --- a/drivers/staging/r8188eu/include/odm_debug.h +++ b/drivers/staging/r8188eu/include/odm_debug.h @@ -96,15 +96,6 @@ RT_PRINTK fmt; \ } -#define ODM_RT_ASSERT(pDM_Odm, expr, fmt) \ - if (!(expr)) { \ - DbgPrint( "Assertion failed! %s at ......\n", #expr); \ - DbgPrint( " ......%s,%s,line=%d\n", __FILE__, \ - __func__, __LINE__); \ - RT_PRINTK fmt; \ - ASSERT(false); \ - } - void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm); #endif /* __ODM_DBG_H__ */ -- 2.31.1