LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk> To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 08/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_HWConfig.c Date: Sat, 31 Jul 2021 01:23:47 +0100 [thread overview] Message-ID: <20210731002353.68479-9-phil@philpotter.co.uk> (raw) In-Reply-To: <20210731002353.68479-1-phil@philpotter.co.uk> Remove ODM_RT_TRACE calls from hal/odm_HWConfig.c, as by removing these calls in this file and others, we can ultimately then remove the macro definition itself, which does not follow best practice. Signed-off-by: Phillip Potter <phil@philpotter.co.uk> --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c index 93a91cce21ec..5f29535590cd 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -535,15 +535,11 @@ enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm, enum rf_radio_path content, enum rf_radio_path rfpath) { - ODM_RT_TRACE(dm_odm, ODM_COMP_INIT, ODM_DBG_LOUD, ("===>ODM_ConfigRFWithHeaderFile\n")); if (dm_odm->SupportICType == ODM_RTL8188E) { if (rfpath == RF_PATH_A) READ_AND_CONFIG(8188E, _RadioA_1T_); - ODM_RT_TRACE(dm_odm, ODM_COMP_INIT, ODM_DBG_LOUD, (" ===> ODM_ConfigRFWithHeaderFile() Radio_A:Rtl8188ERadioA_1TArray\n")); - ODM_RT_TRACE(dm_odm, ODM_COMP_INIT, ODM_DBG_LOUD, (" ===> ODM_ConfigRFWithHeaderFile() Radio_B:Rtl8188ERadioB_1TArray\n")); } - ODM_RT_TRACE(dm_odm, ODM_COMP_INIT, ODM_DBG_TRACE, ("ODM_ConfigRFWithHeaderFile: Radio No %x\n", rfpath)); return HAL_STATUS_SUCCESS; } @@ -557,8 +553,6 @@ enum HAL_STATUS ODM_ConfigBBWithHeaderFile(struct odm_dm_struct *dm_odm, READ_AND_CONFIG(8188E, _AGC_TAB_1T_); } else if (config_tp == CONFIG_BB_PHY_REG_PG) { READ_AND_CONFIG(8188E, _PHY_REG_PG_); - ODM_RT_TRACE(dm_odm, ODM_COMP_INIT, ODM_DBG_LOUD, - (" ===> phy_ConfigBBWithHeaderFile() agc:Rtl8188EPHY_REG_PGArray\n")); } } return HAL_STATUS_SUCCESS; -- 2.31.1
next prev parent reply other threads:[~2021-07-31 0:24 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-31 0:23 [PATCH 00/14] remove include/odm_debug.h Phillip Potter 2021-07-31 0:23 ` [PATCH 01/14] staging: r8188eu: remove ODM_PRINT_ADDR macro definition Phillip Potter 2021-07-31 0:23 ` [PATCH 02/14] staging: r8188eu: remove ODM_dbg_* macro definitions Phillip Potter 2021-07-31 0:23 ` [PATCH 03/14] staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller Phillip Potter 2021-07-31 0:23 ` [PATCH 04/14] staging: r8188eu: remove ODM_RT_TRACE_F macro definition Phillip Potter 2021-07-31 0:23 ` [PATCH 05/14] staging: r8188eu: remove ASSERT ifndef and " Phillip Potter 2021-07-31 0:23 ` [PATCH 06/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/Hal8188ERateAdaptive.c Phillip Potter 2021-07-31 0:23 ` [PATCH 07/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/HalPhyRf_8188e.c Phillip Potter 2021-07-31 0:23 ` Phillip Potter [this message] 2021-07-31 0:23 ` [PATCH 09/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_RTL8188E.c Phillip Potter 2021-07-31 0:23 ` [PATCH 10/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_RegConfig8188E.c Phillip Potter 2021-07-31 0:23 ` [PATCH 11/14] staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm.c Phillip Potter 2021-07-31 0:23 ` [PATCH 12/14] staging: r8188eu: remove ODM_RT_TRACE macro definition Phillip Potter 2021-07-31 0:23 ` [PATCH 13/14] staging: r8188eu: remove DbgPrint and RT_PRINTK macro definitions Phillip Potter 2021-07-31 0:23 ` [PATCH 14/14] staging: r8188eu: remove include/odm_debug.h Phillip Potter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210731002353.68479-9-phil@philpotter.co.uk \ --to=phil@philpotter.co.uk \ --cc=Larry.Finger@lwfinger.net \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).