LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: marvell: make the array name static, makes object smaller
@ 2021-08-01 15:06 Colin King
  2021-08-02 22:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-08-01 15:06 UTC (permalink / raw)
  To: Mirko Lindner, David S . Miller, Jakub Kicinski, netdev
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Don't populate the const array name on the stack but instead it
static. Makes the object code smaller by 28 bytes. Add a missing
const to clean up a checkpatch warning.

Before:
   text    data   bss     dec     hex filename
 124565   31565   384  156514   26362 drivers/net/ethernet/marvell/sky2.o

After:
   text    data   bss     dec     hex filename
 124441   31661   384  156486   26346 drivers/net/ethernet/marvell/sky2.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 743ca96527fa..4f51882d83ca 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4884,7 +4884,7 @@ static int sky2_test_msi(struct sky2_hw *hw)
 /* This driver supports yukon2 chipset only */
 static const char *sky2_name(u8 chipid, char *buf, int sz)
 {
-	const char *name[] = {
+	static const char *const name[] = {
 		"XL",		/* 0xb3 */
 		"EC Ultra", 	/* 0xb4 */
 		"Extreme",	/* 0xb5 */
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: marvell: make the array name static, makes object smaller
  2021-08-01 15:06 [PATCH] net: marvell: make the array name static, makes object smaller Colin King
@ 2021-08-02 22:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-02 22:10 UTC (permalink / raw)
  To: Colin King; +Cc: mlindner, davem, kuba, netdev, kernel-janitors, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun,  1 Aug 2021 16:06:47 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the const array name on the stack but instead it
> static. Makes the object code smaller by 28 bytes. Add a missing
> const to clean up a checkpatch warning.
> 
> Before:
>    text    data   bss     dec     hex filename
>  124565   31565   384  156514   26362 drivers/net/ethernet/marvell/sky2.o
> 
> [...]

Here is the summary with links:
  - net: marvell: make the array name static, makes object smaller
    https://git.kernel.org/netdev/net-next/c/628fe1cedda6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-02 22:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-01 15:06 [PATCH] net: marvell: make the array name static, makes object smaller Colin King
2021-08-02 22:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox