LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH linux-next] tools: remove unneeded semicolon
@ 2021-08-02 7:14 cgel.zte
2021-08-24 14:39 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-08-02 7:14 UTC (permalink / raw)
To: jasowang
Cc: john.stultz, tglx, sboyd, shuah, mst, zhang.yunkai, linux-kernel,
linux-kselftest, virtualization, Zeal Robot
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
Fix the following coccicheck REVIEW:
./tools/testing/selftests/timers/inconsistency-check.c:75:2-3 REVIEW
Unneeded semicolon
./tools/testing/selftests/timers/set-timer-lat.c:83:2-3 REVIEW Unneeded
semicolon
./tools/virtio/virtio-trace/trace-agent-ctl.c:78:2-3 REVIEW Unneeded
semicolon
./tools/testing/selftests/timers/nanosleep.c:75:2-3 REVIEW Unneeded
semicolon
./tools/testing/selftests/timers/nsleep-lat.c:75:2-3 REVIEW Unneeded
semicolon
./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3 REVIEW
Unneeded semicolon
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
tools/testing/selftests/timers/alarmtimer-suspend.c | 2 +-
tools/testing/selftests/timers/inconsistency-check.c | 2 +-
tools/testing/selftests/timers/nanosleep.c | 2 +-
tools/testing/selftests/timers/nsleep-lat.c | 2 +-
tools/testing/selftests/timers/set-timer-lat.c | 2 +-
tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
index 4da09dbf83ba..54da4b088f4c 100644
--- a/tools/testing/selftests/timers/alarmtimer-suspend.c
+++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
@@ -79,7 +79,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
index 022d3ffe3fbf..e6756d9c60a7 100644
--- a/tools/testing/selftests/timers/inconsistency-check.c
+++ b/tools/testing/selftests/timers/inconsistency-check.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
index 71b5441c2fd9..433a09676aeb 100644
--- a/tools/testing/selftests/timers/nanosleep.c
+++ b/tools/testing/selftests/timers/nanosleep.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
index eb3e79ed7b4a..a7ca9825e106 100644
--- a/tools/testing/selftests/timers/nsleep-lat.c
+++ b/tools/testing/selftests/timers/nsleep-lat.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
index 50da45437daa..d60bbcad487f 100644
--- a/tools/testing/selftests/timers/set-timer-lat.c
+++ b/tools/testing/selftests/timers/set-timer-lat.c
@@ -80,7 +80,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c
index 73d253d4b559..39860be6e2d8 100644
--- a/tools/virtio/virtio-trace/trace-agent-ctl.c
+++ b/tools/virtio/virtio-trace/trace-agent-ctl.c
@@ -75,7 +75,7 @@ static int wait_order(int ctl_fd)
if (ret)
break;
- };
+ }
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] tools: remove unneeded semicolon
2021-08-02 7:14 [PATCH linux-next] tools: remove unneeded semicolon cgel.zte
@ 2021-08-24 14:39 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2021-08-24 14:39 UTC (permalink / raw)
To: cgel.zte, jasowang
Cc: john.stultz, tglx, sboyd, shuah, mst, zhang.yunkai, linux-kernel,
linux-kselftest, virtualization, Zeal Robot, Shuah Khan
On 8/2/21 1:14 AM, cgel.zte@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> Fix the following coccicheck REVIEW:
> ./tools/testing/selftests/timers/inconsistency-check.c:75:2-3 REVIEW
> Unneeded semicolon
> ./tools/testing/selftests/timers/set-timer-lat.c:83:2-3 REVIEW Unneeded
> semicolon
> ./tools/virtio/virtio-trace/trace-agent-ctl.c:78:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nanosleep.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nsleep-lat.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3 REVIEW
> Unneeded semicolon
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
> tools/testing/selftests/timers/alarmtimer-suspend.c | 2 +-
> tools/testing/selftests/timers/inconsistency-check.c | 2 +-
> tools/testing/selftests/timers/nanosleep.c | 2 +-
> tools/testing/selftests/timers/nsleep-lat.c | 2 +-
> tools/testing/selftests/timers/set-timer-lat.c | 2 +-
> tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
> index 4da09dbf83ba..54da4b088f4c 100644
> --- a/tools/testing/selftests/timers/alarmtimer-suspend.c
> +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
> @@ -79,7 +79,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
> diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
> index 022d3ffe3fbf..e6756d9c60a7 100644
> --- a/tools/testing/selftests/timers/inconsistency-check.c
> +++ b/tools/testing/selftests/timers/inconsistency-check.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 71b5441c2fd9..433a09676aeb 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
> diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
> index eb3e79ed7b4a..a7ca9825e106 100644
> --- a/tools/testing/selftests/timers/nsleep-lat.c
> +++ b/tools/testing/selftests/timers/nsleep-lat.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> index 50da45437daa..d60bbcad487f 100644
> --- a/tools/testing/selftests/timers/set-timer-lat.c
> +++ b/tools/testing/selftests/timers/set-timer-lat.c
> @@ -80,7 +80,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
> diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c
> index 73d253d4b559..39860be6e2d8 100644
> --- a/tools/virtio/virtio-trace/trace-agent-ctl.c
> +++ b/tools/virtio/virtio-trace/trace-agent-ctl.c
> @@ -75,7 +75,7 @@ static int wait_order(int ctl_fd)
>
> if (ret)
> break;
> - };
> + }
>
> return ret;
>
>
We can't accept this patch. The from and Signed-off-by don't match.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] tools: remove unneeded semicolon
2021-08-20 3:38 CGEL
@ 2021-08-24 14:41 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2021-08-24 14:41 UTC (permalink / raw)
To: CGEL, Paolo Bonzini
Cc: Shuah Khan, kvm, linux-kselftest, linux-kernel, jing yangyang,
Zeal Robot, Shuah Khan
On 8/19/21 9:38 PM, CGEL wrote:
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> Eliminate the following coccicheck warning:
>
> ./tools/testing/selftests/kvm/access_tracking_perf_test.c:234:3-4:Unneeded semicolon
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
> tools/testing/selftests/kvm/access_tracking_perf_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/access_tracking_perf_test.c b/tools/testing/selftests/kvm/access_tracking_perf_test.c
> index 71e277c..02a1c0f 100644
> --- a/tools/testing/selftests/kvm/access_tracking_perf_test.c
> +++ b/tools/testing/selftests/kvm/access_tracking_perf_test.c
> @@ -231,7 +231,7 @@ static void *vcpu_thread_main(void *arg)
> case ITERATION_MARK_IDLE:
> mark_vcpu_memory_idle(vm, vcpu_id);
> break;
> - };
> + }
>
> vcpu_last_completed_iteration[vcpu_id] = current_iteration;
> }
>
We can't accept this patch. The from and Signed-off-by don't match.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH linux-next] tools: remove unneeded semicolon
@ 2021-08-20 3:38 CGEL
2021-08-24 14:41 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: CGEL @ 2021-08-20 3:38 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Shuah Khan, kvm, linux-kselftest, linux-kernel, jing yangyang,
Zeal Robot
From: jing yangyang <jing.yangyang@zte.com.cn>
Eliminate the following coccicheck warning:
./tools/testing/selftests/kvm/access_tracking_perf_test.c:234:3-4:Unneeded semicolon
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
tools/testing/selftests/kvm/access_tracking_perf_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/access_tracking_perf_test.c b/tools/testing/selftests/kvm/access_tracking_perf_test.c
index 71e277c..02a1c0f 100644
--- a/tools/testing/selftests/kvm/access_tracking_perf_test.c
+++ b/tools/testing/selftests/kvm/access_tracking_perf_test.c
@@ -231,7 +231,7 @@ static void *vcpu_thread_main(void *arg)
case ITERATION_MARK_IDLE:
mark_vcpu_memory_idle(vm, vcpu_id);
break;
- };
+ }
vcpu_last_completed_iteration[vcpu_id] = current_iteration;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-24 14:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 7:14 [PATCH linux-next] tools: remove unneeded semicolon cgel.zte
2021-08-24 14:39 ` Shuah Khan
2021-08-20 3:38 CGEL
2021-08-24 14:41 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).