LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: r8188eu: core: Change the length of an array
@ 2021-08-02 15:58 Fabio M. De Francesco
  2021-08-02 16:01 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio M. De Francesco @ 2021-08-02 15:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Larry Finger, linux-staging, linux-kernel,
	Dan Carpenter
  Cc: Fabio M. De Francesco

IPX_NODE_LEN == 6, while addr.f1 should only have 4 elements.
Replace IPX_NODE_LEN with 4. In the while, remove the excess spaces
before the fields of the union.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_br_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index 8f434768dd15..c585224080c6 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -137,9 +137,9 @@ static inline void __nat25_generate_ipx_network_addr_with_node(unsigned char *ne
 				__be32 *ipxNetAddr, unsigned char *ipxNodeAddr)
 {
 	union {
-                unsigned int f0;
-                unsigned char f1[IPX_NODE_LEN];
-        } addr;
+		unsigned int f0;
+		unsigned char f1[4];
+	} addr;
 
 	memset(networkAddr, 0, MAX_NETWORK_ADDR_LEN);
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: r8188eu: core: Change the length of an array
  2021-08-02 15:58 [PATCH] staging: r8188eu: core: Change the length of an array Fabio M. De Francesco
@ 2021-08-02 16:01 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-02 16:01 UTC (permalink / raw)
  To: Fabio M. De Francesco
  Cc: Larry Finger, linux-staging, linux-kernel, Dan Carpenter

On Mon, Aug 02, 2021 at 05:58:17PM +0200, Fabio M. De Francesco wrote:
> IPX_NODE_LEN == 6, while addr.f1 should only have 4 elements.
> Replace IPX_NODE_LEN with 4. In the while, remove the excess spaces
> before the fields of the union.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

What is the commit id that this patch fixes?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-02 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 15:58 [PATCH] staging: r8188eu: core: Change the length of an array Fabio M. De Francesco
2021-08-02 16:01 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).