From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71F6C4320A for ; Mon, 2 Aug 2021 18:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B88C660F36 for ; Mon, 2 Aug 2021 18:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230415AbhHBSdv (ORCPT ); Mon, 2 Aug 2021 14:33:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52327 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhHBSdu (ORCPT ); Mon, 2 Aug 2021 14:33:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627929219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u8cNuKavrSy3Q2eP4G8hJso7GgWtVrDgG0yqiTGqFog=; b=Dr/T1VPBCDc37hE3AGjVT1ioNtZQHoUCczTmBuW0vEm5a8ISugRh7A3paq2TwIYXFgSXFU SZYKsn19MloxVuItn/pWFUPq/LL3uRzYiFSQwtFrWQ2eBLO3SoenjKZRHhIwIjKXpwqV50 ss1PAir6SWcjIi3sZGmsT5Mf8DkNBKk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-B_RjfL8SOJWT2_Jy58FmNg-1; Mon, 02 Aug 2021 14:33:36 -0400 X-MC-Unique: B_RjfL8SOJWT2_Jy58FmNg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 142D0802923; Mon, 2 Aug 2021 18:33:34 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AB4D27CAB; Mon, 2 Aug 2021 18:33:30 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , Joerg Roedel , Borislav Petkov , Sean Christopherson , Jim Mattson , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Suravee Suthikulpanit , Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , Maxim Levitsky Subject: [PATCH v3 00/12] My AVIC patch queue Date: Mon, 2 Aug 2021 21:33:17 +0300 Message-Id: <20210802183329.2309921-1-mlevitsk@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi!=0D =0D This is a series of bugfixes to the AVIC dynamic inhibition, which was=0D made while trying to fix bugs as much as possible in this area and trying=0D to make the AVIC+SYNIC conditional enablement work.=0D =0D * Patches 1-6 are code from Sean Christopherson which=0D implement an alternative approach of inhibiting AVIC without=0D disabling its memslot.=0D Those patches are new in this version of the patchset.=0D =0D * Patches 7-8 in this series fix a race condition which can cause=0D a lost write from a guest to APIC when the APIC write races=0D the AVIC un-inhibition, and add a warning to catch this problem=0D if it re-emerges again.=0D =0D V3: moved the mutex to kvm.arch and added comment=0D =0D * Patch 9 is the patch from Vitaly about allowing AVIC with SYNC=0D as long as the guest doesn=E2=80=99t use the AutoEOI feature. I only slig= htly=0D changed it to expose the AutoEOI cpuid bit regardless of AVIC enablement.= =0D =0D * Patch 10 is a new patch in this version, which is a refactoring that is n= ow=0D possible in SVM AVIC inhibition code, because the RCU lock is not dropped= anymore.=0D =0D * Patch 11 fixes another issue I found in AVIC inhibit code:=0D =0D Currently avic_vcpu_load/avic_vcpu_put are called on userspace entry/exit= =0D from KVM (aka kvm_vcpu_get/kvm_vcpu_put), and these functions update the= =0D "is running" bit in the AVIC physical ID remap table and update the=0D target vCPU in iommu code.=0D =0D However both of these functions don't do anything when AVIC is inhibited= =0D thus the "is running" bit will be kept enabled during the exit to userspa= ce.=0D This shouldn't be a big issue as the caller=0D doesn't use the AVIC when inhibited but still inconsistent and can trigge= r=0D a warning about this in avic_vcpu_load.=0D =0D To be on the safe side I think it makes sense to call=0D avic_vcpu_put/avic_vcpu_load when inhibiting/uninhibiting the AVIC.=0D This will ensure that the work these functions do is matched.=0D =0D * Patch 12 (also new in this series) removes the pointless APIC base=0D relocation from AVIC to make it consistent with the rest of KVM.=0D =0D (both AVIC and APICv only support default base, while regular KVM,=0D sort of support any APIC base as long as it is not RAM.=0D If guest attempts to relocate APIC base to non RAM area,=0D while APICv/AVIC are active, the new base will be non accelerated,=0D while the default base will continue to be AVIC/APICv backed).=0D =0D Best regards,=0D Maxim Levitsky=0D =0D Maxim Levitsky (10):=0D KVM: x86/mmu: bump mmu notifier count in kvm_zap_gfn_range=0D KVM: x86/mmu: rename try_async_pf to kvm_faultin_pfn=0D KVM: x86/mmu: allow kvm_faultin_pfn to return page fault handling code=0D KVM: x86/mmu: allow APICv memslot to be partially enabled=0D KVM: x86: don't disable APICv memslot when inhibited=0D KVM: x86: APICv: fix race in kvm_request_apicv_update on SVM=0D KVM: SVM: add warning for mistmatch between AVIC state and AVIC access=0D page state=0D KVM: SVM: remove svm_toggle_avic_for_irq_window=0D KVM: SVM: call avic_vcpu_load/avic_vcpu_put when enabling/disabling=0D AVIC=0D KVM: SVM: AVIC: drop unsupported AVIC base relocation code=0D =0D Sean Christopherson (1):=0D Revert "KVM: x86/mmu: Allow zap gfn range to operate under the mmu=0D read lock"=0D =0D Vitaly Kuznetsov (1):=0D KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in=0D use=0D =0D arch/x86/include/asm/kvm-x86-ops.h | 1 -=0D arch/x86/include/asm/kvm_host.h | 7 ++-=0D arch/x86/kvm/hyperv.c | 27 ++++++++---=0D arch/x86/kvm/mmu/mmu.c | 69 ++++++++++++++++----------=0D arch/x86/kvm/mmu/paging_tmpl.h | 6 +--=0D arch/x86/kvm/mmu/tdp_mmu.c | 15 ++----=0D arch/x86/kvm/mmu/tdp_mmu.h | 11 ++---=0D arch/x86/kvm/svm/avic.c | 77 ++++++++++++------------------=0D arch/x86/kvm/svm/svm.c | 23 +++++----=0D arch/x86/kvm/svm/svm.h | 8 ----=0D arch/x86/kvm/x86.c | 56 +++++++++++++---------=0D include/linux/kvm_host.h | 5 ++=0D virt/kvm/kvm_main.c | 7 ++-=0D 13 files changed, 166 insertions(+), 146 deletions(-)=0D =0D -- =0D 2.26.3=0D =0D