LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] binder: Add invalid handle info in user error log
@ 2021-08-02 22:04 Ramji Jiyani
  0 siblings, 0 replies; only message in thread
From: Ramji Jiyani @ 2021-08-02 22:04 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
	Martijn Coenen, Joel Fernandes, Christian Brauner,
	Hridya Valsaraju, Suren Baghdasaryan
  Cc: Ramji Jiyani, Todd Kjos, kernel-team, linux-kernel

In the case of a failed transaction, only the thread and process id are
logged. Add the handle info for the reference to the target node in user
error log to aid debugging.

Signed-off-by: Ramji Jiyani <ramjiyani@google.com>
Acked-by: Todd Kjos <tkjos@google.com>
---
v1 -> v2: Rephrased the commit message as per review comment
---
 drivers/android/binder.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index bcec598b89f2..d9030cb6b1e4 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2547,8 +2547,8 @@ static void binder_transaction(struct binder_proc *proc,
 						ref->node, &target_proc,
 						&return_error);
 			} else {
-				binder_user_error("%d:%d got transaction to invalid handle\n",
-						  proc->pid, thread->pid);
+				binder_user_error("%d:%d got transaction to invalid handle, %u\n",
+						  proc->pid, thread->pid, tr->target.handle);
 				return_error = BR_FAILED_REPLY;
 			}
 			binder_proc_unlock(proc);
-- 
2.32.0.554.ge1b32706d8-goog


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-02 22:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 22:04 [PATCH v2] binder: Add invalid handle info in user error log Ramji Jiyani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).