LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Amey Narkhede <ameynarkhede03@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	alex.williamson@redhat.com,
	Raphael Norwitz <raphael.norwitz@nutanix.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	kw@linux.com, Shanker Donthineni <sdonthineni@nvidia.com>,
	Sinan Kaya <okaya@kernel.org>, Len Brown <lenb@kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods
Date: Tue, 3 Aug 2021 10:19:29 +0530	[thread overview]
Message-ID: <20210803044929.p22ren6wwl3jff3f@archlinux> (raw)
In-Reply-To: <20210802224420.GA1472058@bjorn-Precision-5520>

On 21/08/02 05:44PM, Bjorn Helgaas wrote:
> On Sun, Aug 01, 2021 at 07:55:11PM +0530, Amey Narkhede wrote:
> > Currently there is separate function pcie_has_flr() to probe if PCIe FLR
> > is supported by the device which does not match the calling convention
> > followed by reset methods which use second function argument to decide
> > whether to probe or not. Add new function pcie_reset_flr() that follows
> > the calling convention of reset methods.
> >
> > Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
> > ---
> >  drivers/crypto/cavium/nitrox/nitrox_main.c |  4 +--
> >  drivers/pci/pci.c                          | 40 +++++++++++++++-------
> >  drivers/pci/pcie/aer.c                     | 12 +++----
> >  drivers/pci/quirks.c                       |  9 ++---
> >  include/linux/pci.h                        |  2 +-
> >  5 files changed, 38 insertions(+), 29 deletions(-)
>
> >  int pcie_flr(struct pci_dev *dev)
> >  {
> > @@ -4655,7 +4653,26 @@ int pcie_flr(struct pci_dev *dev)
> >
> >  	return pci_dev_wait(dev, "FLR", PCIE_RESET_READY_POLL_MS);
> >  }
> > -EXPORT_SYMBOL_GPL(pcie_flr);
> > +EXPORT_SYMBOL(pcie_flr);
>
> Why this change?  If it's unintentional and there's no other reason to
> repost, I can fix it up locally.
Yeah my bad it was unintentional.

  reply	other threads:[~2021-08-03  4:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 14:25 [PATCH v13 0/9] PCI: Expose and manage PCI device reset Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 1/9] PCI: Cache PCIe FLR capability Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods Amey Narkhede
2021-08-01 17:04   ` kernel test robot
2021-08-01 17:05   ` [RFC PATCH] PCI: pcie_has_flr() can be static kernel test robot
2021-08-01 18:17   ` [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods kernel test robot
2021-08-02 22:44   ` Bjorn Helgaas
2021-08-03  4:49     ` Amey Narkhede [this message]
2021-08-01 14:25 ` [PATCH v13 3/9] PCI: Add new array for keeping track of ordering of " Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 4/9] PCI: Remove reset_fn field from pci_dev Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 5/9] PCI: Allow userspace to query and set device reset mechanism Amey Narkhede
2021-08-02 22:55   ` Bjorn Helgaas
2021-08-03  6:34     ` Amey Narkhede
2021-08-03 13:45   ` Shanker R Donthineni
2021-08-01 14:25 ` [PATCH v13 6/9] PCI: Define a function to set ACPI_COMPANION in pci_dev Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 7/9] PCI: Setup ACPI fwnode early and at the same time with OF Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 8/9] PCI: Add support for ACPI _RST reset method Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 9/9] PCI: Change the type of probe argument in reset functions Amey Narkhede
2021-08-02 22:59   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803044929.p22ren6wwl3jff3f@archlinux \
    --to=ameynarkhede03@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=okaya@kernel.org \
    --cc=raphael.norwitz@nutanix.com \
    --cc=rjw@rjwysocki.net \
    --cc=sdonthineni@nvidia.com \
    --subject='Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox