From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CE9C4338F for ; Tue, 3 Aug 2021 08:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B96360555 for ; Tue, 3 Aug 2021 08:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234588AbhHCIoy (ORCPT ); Tue, 3 Aug 2021 04:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234505AbhHCIox (ORCPT ); Tue, 3 Aug 2021 04:44:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F4C4C06175F for ; Tue, 3 Aug 2021 01:44:43 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAq2M-0006F9-UP; Tue, 03 Aug 2021 10:44:34 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1mAq2L-0001sc-0A; Tue, 03 Aug 2021 10:44:33 +0200 Date: Tue, 3 Aug 2021 10:44:32 +0200 From: Oleksij Rempel To: DENG Qingfang Cc: Andrew Lunn , Florian Fainelli , linux-mips@vger.kernel.org, netdev@vger.kernel.org, Russell King , "David S. Miller" , Pengutronix Kernel Team , Jakub Kicinski , Vladimir Oltean , Vivien Didelot , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/1] net: dsa: qca: ar9331: make proper initial port defaults Message-ID: <20210803084432.gvl7dexmhqii6a5s@pengutronix.de> References: <20210803065424.9692-1-o.rempel@pengutronix.de> <20210803081435.2910620-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210803081435.2910620-1-dqfext@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:44:03 up 243 days, 22:50, 25 users, load average: 0.02, 0.08, 0.04 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 03, 2021 at 04:14:35PM +0800, DENG Qingfang wrote: > On Tue, Aug 03, 2021 at 08:54:24AM +0200, Oleksij Rempel wrote: > > + if (dsa_is_cpu_port(ds, port)) { > > + /* CPU port should be allowed to communicate with all user > > + * ports. > > + */ > > + port_mask = dsa_user_ports(ds); > > + /* Enable Atheros header on CPU port. This will allow us > > + * communicate with each port separately > > + */ > > + port_ctrl |= AR9331_SW_PORT_CTRL_HEAD_EN; > > + } else if (dsa_is_user_port(ds, port)) { > > + /* User ports should communicate only with the CPU port. > > + */ > > + port_mask = BIT(dsa_to_port(ds, port)->cpu_dp->index); > > + port_ctrl |= AR9331_SW_PORT_CTRL_LEARN_EN; > > All user ports should start with address learning disabled. > To toggle it, implement .port_pre_bridge_flags and .port_bridge_flags. Ok, thx! Will move it to the separate patch -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |