LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: <alexandru.tachici@analog.com>
Cc: <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] iio: adc: Fix flags in sigma-delta drivers
Date: Tue, 3 Aug 2021 13:47:26 +0100	[thread overview]
Message-ID: <20210803134726.000067f0@Huawei.com> (raw)
In-Reply-To: <20210803091741.8924-1-alexandru.tachici@analog.com>

On Tue, 3 Aug 2021 12:17:41 +0300
<alexandru.tachici@analog.com> wrote:

> In Sigma-Delta devices the SDO line is also used as an interrupt.
> Leaving IRQ on level instead of falling might trigger a sample read
> when the IRQ is enabled, as the SDO line is already low. Not sure
> if SDO line will always imediately go high in ad_sd_buffer_postenable
> before the IRQ is enabled.

ok. That last bit sounds like a good justification.  It might do the
wrong thing on initial startup.  Please resend with that in the patch
descriptions for those you are modifying.

For those where it is being introduced, we probably want to leave the
interrupt type to firmware (i.e. patch 1)

> 
> Also the datasheets seem to explicitly say the falling edge of the SDO
> should be used as an interrupt.

Reference?

> 
> -Alexandru


      reply	other threads:[~2021-08-03 12:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  8:47 alexandru.tachici
2021-07-29  8:47 ` [PATCH 1/3] iio: adc: ad7192: Fix IRQ flag alexandru.tachici
2021-07-29  8:47 ` [PATCH 2/3] iio: adc: ad7780: " alexandru.tachici
2021-07-29  8:47 ` [PATCH 3/3] iio: adc: ad7923: " alexandru.tachici
2021-07-31 14:09 ` [PATCH 0/3] iio: adc: Fix flags in sigma-delta drivers Jonathan Cameron
2021-08-03  9:17   ` alexandru.tachici
2021-08-03 12:47     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803134726.000067f0@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alexandru.tachici@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 0/3] iio: adc: Fix flags in sigma-delta drivers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).