LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters
Date: Tue, 3 Aug 2021 17:01:40 +0300	[thread overview]
Message-ID: <20210803140140.GM25548@kadam> (raw)
In-Reply-To: <2671423.i2fK0j4CO3@localhost.localdomain>

1) I'm pretty sure after a little more review that the patch introduces
   bugs.  The data is supposed to be big endian.

2) The commit message did not clearly describe the "bug" and how the it
   looks like to the user.

3) The way we set variables to zero is we say "foo = 0;"  We do not
   say "foo ^= foo;".  Everyone knows the XOR a variable with itself
   trick but obfuscated code makes us cross.

4) The unions were unnecessary and ugly/bad.

regards,
dan carpenter


  reply	other threads:[~2021-08-03 14:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 18:14 Fabio M. De Francesco
2021-08-02 14:05 ` Dan Carpenter
2021-08-02 14:26   ` Fabio M. De Francesco
2021-08-02 15:21     ` Fabio M. De Francesco
2021-08-03  8:15   ` Fabio M. De Francesco
2021-08-03 14:01     ` Dan Carpenter [this message]
2021-08-04  7:59 ` Dan Carpenter
2021-08-04  9:00   ` Fabio M. De Francesco
2021-08-04  9:58     ` Dan Carpenter
2021-08-04 11:29       ` Fabio M. De Francesco
2021-08-04 12:00         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803140140.GM25548@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).