LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v4 00/10] thread_info: use helpers to snapshot thread flags
@ 2021-08-03  9:54 Mark Rutland
  2021-08-03  9:54 ` [PATCH v4 01/10] thread_info: add " Mark Rutland
                   ` (10 more replies)
  0 siblings, 11 replies; 13+ messages in thread
From: Mark Rutland @ 2021-08-03  9:54 UTC (permalink / raw)
  To: linux-kernel
  Cc: benh, boqun.feng, bp, catalin.marinas, dvyukov, elver, ink,
	jonas, juri.lelli, linux, luto, mark.rutland, mattst88, mingo,
	monstr, mpe, paulmck, paulus, peterz, rth, shorne,
	stefan.kristiansson, tglx, vincent.guittot, will

As thread_info::flags scan be manipulated by remote threads, it is
necessary to use atomics or READ_ONCE() to ensure that code manipulates
a consistent snapshot, but we open-code plain accesses to
thread_info::flags across the kernel tree.

Generally we get away with this, but tools like KCSAN legitimately warn
that there is a data-race, and this is potentially fragile with compiler
optimizations, LTO, etc.

These patches introduce new helpers to snahpshot the thread flags, with
the intent being that these should replace all plain accesses.

Since v1 [1]:
* Drop RFC
* Make read_ti_thread_flags() __always_inline
* Clarify commit messages
* Fix typo in arm64 patch
* Accumulate Reviewed-by / Acked-by tags
* Drop powerpc patch to avoid potential conflicts (per [2])

Since v2 [3]:
* Rebase to v5.14-rc1
* Reinstate powerpc patch

Since v3 [4]:
* Rebase to v5.14-rc4

[1] https://lore.kernel.org/r/20210609122001.18277-1-mark.rutland@arm.com
[2] https://lore.kernel.org/r/87k0mvtgeb.fsf@mpe.ellerman.id.au
[3] https://lore.kernel.org/r/20210621090602.16883-1-mark.rutland@arm.com
[4] https://lore.kernel.org/r/20210713113842.2106-1-mark.rutland@arm.com

Thanks,
Mark.

Mark Rutland (10):
  thread_info: add helpers to snapshot thread flags
  entry: snapshot thread flags
  sched: snapshot thread flags
  alpha: snapshot thread flags
  arm: snapshot thread flags
  arm64: snapshot thread flags
  microblaze: snapshot thread flags
  openrisc: snapshot thread flags
  powerpc: snapshot thread flags
  x86: snapshot thread flags

 arch/alpha/kernel/signal.c          |  2 +-
 arch/arm/kernel/signal.c            |  2 +-
 arch/arm/mm/alignment.c             |  2 +-
 arch/arm64/kernel/ptrace.c          |  4 ++--
 arch/arm64/kernel/signal.c          |  2 +-
 arch/arm64/kernel/syscall.c         |  4 ++--
 arch/microblaze/kernel/signal.c     |  2 +-
 arch/openrisc/kernel/signal.c       |  2 +-
 arch/powerpc/kernel/interrupt.c     | 13 ++++++-------
 arch/powerpc/kernel/ptrace/ptrace.c |  3 +--
 arch/x86/kernel/process.c           |  8 ++++----
 arch/x86/kernel/process.h           |  6 +++---
 arch/x86/mm/tlb.c                   |  2 +-
 include/linux/entry-kvm.h           |  2 +-
 include/linux/thread_info.h         | 14 ++++++++++++++
 kernel/entry/common.c               |  4 ++--
 kernel/entry/kvm.c                  |  4 ++--
 kernel/sched/core.c                 |  2 +-
 18 files changed, 45 insertions(+), 33 deletions(-)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-08-25  9:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03  9:54 [PATCH v4 00/10] thread_info: use helpers to snapshot thread flags Mark Rutland
2021-08-03  9:54 ` [PATCH v4 01/10] thread_info: add " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 02/10] entry: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 03/10] sched: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 04/10] alpha: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 05/10] arm: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 06/10] arm64: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 07/10] microblaze: " Mark Rutland
2021-08-25  9:03   ` Michal Simek
2021-08-03  9:54 ` [PATCH v4 08/10] openrisc: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 09/10] powerpc: " Mark Rutland
2021-08-03  9:54 ` [PATCH v4 10/10] x86: " Mark Rutland
2021-08-03 16:01 ` [PATCH v4 00/10] thread_info: use helpers to " Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).