From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77B9C4320A for ; Tue, 3 Aug 2021 16:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDFB560F94 for ; Tue, 3 Aug 2021 16:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233209AbhHCQTv (ORCPT ); Tue, 3 Aug 2021 12:19:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:53832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233239AbhHCQTs (ORCPT ); Tue, 3 Aug 2021 12:19:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2318260F8F; Tue, 3 Aug 2021 16:19:33 +0000 (UTC) Date: Tue, 3 Aug 2021 17:19:26 +0100 From: Catalin Marinas To: Masahiro Yamada Cc: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org, Will Deacon , Thomas Bogendoerfer , Palmer Dabbelt , Michael Ellerman , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Message-ID: <20210803161925.GC5786@arm.com> References: <20210731060020.12913-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada Acked-by: Catalin Marinas