LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [amir73il:fsnotify-perf 2/5] fs/notify/mark.c:227:22: warning: variable 'sb' set but not used
Date: Tue, 3 Aug 2021 16:21:43 +0800	[thread overview]
Message-ID: <202108031634.fxlil47Q-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2632 bytes --]

tree:   https://github.com/amir73il/linux fsnotify-perf
head:   7446ba772ae107ab937cd04e8800236d6235dc4c
commit: ae00302ec41c4dae058c61c56a47134ecae77a36 [2/5] fsnotify: count s_fsnotify_inode_refs for attached connectors
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/amir73il/linux/commit/ae00302ec41c4dae058c61c56a47134ecae77a36
        git remote add amir73il https://github.com/amir73il/linux
        git fetch --no-tags amir73il fsnotify-perf
        git checkout ae00302ec41c4dae058c61c56a47134ecae77a36
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/notify/mark.c: In function 'fsnotify_drop_object':
>> fs/notify/mark.c:227:22: warning: variable 'sb' set but not used [-Wunused-but-set-variable]
     227 |  struct super_block *sb;
         |                      ^~


vim +/sb +227 fs/notify/mark.c

6b3f05d24d355f Jan Kara       2016-12-21  222  
721fb6fbfd2132 Jan Kara       2018-10-17  223  /* Drop object reference originally held by a connector */
721fb6fbfd2132 Jan Kara       2018-10-17  224  static void fsnotify_drop_object(unsigned int type, void *objp)
721fb6fbfd2132 Jan Kara       2018-10-17  225  {
721fb6fbfd2132 Jan Kara       2018-10-17  226  	struct inode *inode;
721fb6fbfd2132 Jan Kara       2018-10-17 @227  	struct super_block *sb;
721fb6fbfd2132 Jan Kara       2018-10-17  228  
721fb6fbfd2132 Jan Kara       2018-10-17  229  	if (!objp)
721fb6fbfd2132 Jan Kara       2018-10-17  230  		return;
721fb6fbfd2132 Jan Kara       2018-10-17  231  	/* Currently only inode references are passed to be dropped */
721fb6fbfd2132 Jan Kara       2018-10-17  232  	if (WARN_ON_ONCE(type != FSNOTIFY_OBJ_TYPE_INODE))
721fb6fbfd2132 Jan Kara       2018-10-17  233  		return;
721fb6fbfd2132 Jan Kara       2018-10-17  234  	inode = objp;
721fb6fbfd2132 Jan Kara       2018-10-17  235  	sb = inode->i_sb;
ae00302ec41c4d Amir Goldstein 2020-07-26  236  	fsnotify_put_inode_ref(inode);
721fb6fbfd2132 Jan Kara       2018-10-17  237  }
721fb6fbfd2132 Jan Kara       2018-10-17  238  

:::::: The code at line 227 was first introduced by commit
:::::: 721fb6fbfd2132164c2e8777cc837f9b2c1794dc fsnotify: Fix busy inodes during unmount

:::::: TO: Jan Kara <jack@suse.cz>
:::::: CC: Jan Kara <jack@suse.cz>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41691 bytes --]

                 reply	other threads:[~2021-08-03  8:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108031634.fxlil47Q-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=amir73il@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [amir73il:fsnotify-perf 2/5] fs/notify/mark.c:227:22: warning: variable '\''sb'\'' set but not used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).