LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] workqueue: Replace deprecated ida_simple_*() with ida_alloc()/ida_free()
@ 2021-08-04  3:50 Zhen Lei
  2021-08-09 22:33 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-08-04  3:50 UTC (permalink / raw)
  To: Tejun Heo, Lai Jiangshan, linux-kernel; +Cc: Zhen Lei

Replace ida_simple_get() with ida_alloc() and ida_simple_remove() with
ida_free(), the latter is more concise and intuitive.

In addition, if ida_alloc() fails, NULL is returned directly. This
eliminates unnecessary initialization of two local variables and an 'if'
judgment.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 kernel/workqueue.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 542c2d03dab6..80595556e525 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1912,14 +1912,14 @@ static void worker_detach_from_pool(struct worker *worker)
  */
 static struct worker *create_worker(struct worker_pool *pool)
 {
-	struct worker *worker = NULL;
-	int id = -1;
+	struct worker *worker;
+	int id;
 	char id_buf[16];
 
 	/* ID is needed to determine kthread name */
-	id = ida_simple_get(&pool->worker_ida, 0, 0, GFP_KERNEL);
+	id = ida_alloc(&pool->worker_ida, GFP_KERNEL);
 	if (id < 0)
-		goto fail;
+		return NULL;
 
 	worker = alloc_worker(pool->node);
 	if (!worker)
@@ -1954,8 +1954,7 @@ static struct worker *create_worker(struct worker_pool *pool)
 	return worker;
 
 fail:
-	if (id >= 0)
-		ida_simple_remove(&pool->worker_ida, id);
+	ida_free(&pool->worker_ida, id);
 	kfree(worker);
 	return NULL;
 }
@@ -2378,7 +2377,7 @@ static int worker_thread(void *__worker)
 		set_pf_worker(false);
 
 		set_task_comm(worker->task, "kworker/dying");
-		ida_simple_remove(&pool->worker_ida, worker->id);
+		ida_free(&pool->worker_ida, worker->id);
 		worker_detach_from_pool(worker);
 		kfree(worker);
 		return 0;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] workqueue: Replace deprecated ida_simple_*() with ida_alloc()/ida_free()
  2021-08-04  3:50 [PATCH] workqueue: Replace deprecated ida_simple_*() with ida_alloc()/ida_free() Zhen Lei
@ 2021-08-09 22:33 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2021-08-09 22:33 UTC (permalink / raw)
  To: Zhen Lei; +Cc: Lai Jiangshan, linux-kernel

On Wed, Aug 04, 2021 at 11:50:36AM +0800, Zhen Lei wrote:
> Replace ida_simple_get() with ida_alloc() and ida_simple_remove() with
> ida_free(), the latter is more concise and intuitive.
> 
> In addition, if ida_alloc() fails, NULL is returned directly. This
> eliminates unnecessary initialization of two local variables and an 'if'
> judgment.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Applied to wq/for-5.15.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-09 22:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04  3:50 [PATCH] workqueue: Replace deprecated ida_simple_*() with ida_alloc()/ida_free() Zhen Lei
2021-08-09 22:33 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).